aa9c5b9af2
Patch Set 6:
(1 comment)
Patch-set: 6
CC: Gerrit User 4550 <4550@1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71>
Attention: {"person_ident":"Gerrit User 29242 \u003c29242@1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4550\u003e replied on the change"}
75 lines
No EOL
2.2 KiB
Text
75 lines
No EOL
2.2 KiB
Text
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2c7d6d3b_7d613776",
|
|
"filename": "BoardConfig.mk",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 35591
|
|
},
|
|
"writtenOn": "2025-08-13T23:55:44Z",
|
|
"side": 1,
|
|
"message": "Genuine question : shouldn\u0027t this be set to the board\u0027s codename (blair for sm6375 if I\u0027m not wrong) instead of the device\u0027s codename ?",
|
|
"range": {
|
|
"startLine": 15,
|
|
"startChar": 32,
|
|
"endLine": 15,
|
|
"endChar": 38
|
|
},
|
|
"revId": "71c9c97a3f1ca52a68d4f3ec83318b9df93766b2",
|
|
"serverId": "1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7cf099fb_27af1093",
|
|
"filename": "BoardConfig.mk",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 29242
|
|
},
|
|
"writtenOn": "2025-08-14T02:33:10Z",
|
|
"side": 1,
|
|
"message": "No, common tree inherits the common configs for these devices.\n\nhttps://github.com/LineageOS/android_device_motorola_sm6375-common/blob/2b28552357943d3faaad11fd70a608e2bcf5fcc6/BoardConfigCommon.mk#L50",
|
|
"parentUuid": "2c7d6d3b_7d613776",
|
|
"range": {
|
|
"startLine": 15,
|
|
"startChar": 32,
|
|
"endLine": 15,
|
|
"endChar": 38
|
|
},
|
|
"revId": "71c9c97a3f1ca52a68d4f3ec83318b9df93766b2",
|
|
"serverId": "1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b57ebcb7_1f2d9158",
|
|
"filename": "BoardConfig.mk",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 4550
|
|
},
|
|
"writtenOn": "2025-08-22T13:52:49Z",
|
|
"side": 1,
|
|
"message": "TARGET_BOOTLOADER_BOARD_NAME is set to the name that the bootloader reports. On motorola devices, the bootloader properly reports the device name as the board name.",
|
|
"parentUuid": "7cf099fb_27af1093",
|
|
"range": {
|
|
"startLine": 15,
|
|
"startChar": 32,
|
|
"endLine": 15,
|
|
"endChar": 38
|
|
},
|
|
"revId": "71c9c97a3f1ca52a68d4f3ec83318b9df93766b2",
|
|
"serverId": "1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71"
|
|
}
|
|
]
|
|
} |