From 5e8377d9b90bd792ceee4f73237cd44498e78c58 Mon Sep 17 00:00:00 2001 From: Jesse Chan Date: Thu, 18 Jul 2024 12:56:42 +0530 Subject: [PATCH] sm6375-common: power-libperfmgr: remove Google-specific VR and camera hints Change-Id: Iac0e65a16f660583d3400a35622113d35d8d1d27 --- power-libperfmgr/Power.cpp | 67 ++++---------------------------------- power-libperfmgr/Power.h | 1 - 2 files changed, 7 insertions(+), 61 deletions(-) diff --git a/power-libperfmgr/Power.cpp b/power-libperfmgr/Power.cpp index 5324739..a6d6fe1 100644 --- a/power-libperfmgr/Power.cpp +++ b/power-libperfmgr/Power.cpp @@ -44,7 +44,6 @@ constexpr char kPowerHalRenderingProp[] = "vendor.powerhal.rendering"; Power::Power(std::shared_ptr hm) : mHintManager(hm), mInteractionHandler(nullptr), - mVRModeOn(false), mSustainedPerfModeOn(false) { mInteractionHandler = std::make_unique(mHintManager); mInteractionHandler->Init(); @@ -54,15 +53,6 @@ Power::Power(std::shared_ptr hm) ALOGI("Initialize with SUSTAINED_PERFORMANCE on"); mHintManager->DoHint("SUSTAINED_PERFORMANCE"); mSustainedPerfModeOn = true; - } else if (state == "VR") { - ALOGI("Initialize with VR on"); - mHintManager->DoHint(state); - mVRModeOn = true; - } else if (state == "VR_SUSTAINED_PERFORMANCE") { - ALOGI("Initialize with SUSTAINED_PERFORMANCE and VR on"); - mHintManager->DoHint("VR_SUSTAINED_PERFORMANCE"); - mSustainedPerfModeOn = true; - mVRModeOn = true; } else { ALOGI("Initialize PowerHAL"); } @@ -88,43 +78,13 @@ ndk::ScopedAStatus Power::setMode(Mode type, bool enabled) { ATRACE_INT(toString(type).c_str(), enabled); switch (type) { case Mode::SUSTAINED_PERFORMANCE: - if (enabled && !mSustainedPerfModeOn) { - if (!mVRModeOn) { // Sustained mode only. - mHintManager->DoHint("SUSTAINED_PERFORMANCE"); - } else { // Sustained + VR mode. - mHintManager->EndHint("VR"); - mHintManager->DoHint("VR_SUSTAINED_PERFORMANCE"); - } - mSustainedPerfModeOn = true; - } else if (!enabled && mSustainedPerfModeOn) { - mHintManager->EndHint("VR_SUSTAINED_PERFORMANCE"); - mHintManager->EndHint("SUSTAINED_PERFORMANCE"); - if (mVRModeOn) { // Switch back to VR Mode. - mHintManager->DoHint("VR"); - } - mSustainedPerfModeOn = false; - } - break; - case Mode::VR: - if (enabled && !mVRModeOn) { - if (!mSustainedPerfModeOn) { // VR mode only. - mHintManager->DoHint("VR"); - } else { // Sustained + VR mode. - mHintManager->EndHint("SUSTAINED_PERFORMANCE"); - mHintManager->DoHint("VR_SUSTAINED_PERFORMANCE"); - } - mVRModeOn = true; - } else if (!enabled && mVRModeOn) { - mHintManager->EndHint("VR_SUSTAINED_PERFORMANCE"); - mHintManager->EndHint("VR"); - if (mSustainedPerfModeOn) { // Switch back to sustained Mode. - mHintManager->DoHint("SUSTAINED_PERFORMANCE"); - } - mVRModeOn = false; + if (enabled) { + mHintManager->DoHint("SUSTAINED_PERFORMANCE"); } + mSustainedPerfModeOn = true; break; case Mode::LAUNCH: - if (mVRModeOn || mSustainedPerfModeOn) { + if (mSustainedPerfModeOn) { break; } [[fallthrough]]; @@ -142,14 +102,6 @@ ndk::ScopedAStatus Power::setMode(Mode type, bool enabled) { [[fallthrough]]; case Mode::AUDIO_STREAMING_LOW_LATENCY: [[fallthrough]]; - case Mode::CAMERA_STREAMING_SECURE: - [[fallthrough]]; - case Mode::CAMERA_STREAMING_LOW: - [[fallthrough]]; - case Mode::CAMERA_STREAMING_MID: - [[fallthrough]]; - case Mode::CAMERA_STREAMING_HIGH: - [[fallthrough]]; default: if (enabled) { mHintManager->DoHint(toString(type)); @@ -174,7 +126,7 @@ ndk::ScopedAStatus Power::setBoost(Boost type, int32_t durationMs) { ATRACE_INT(toString(type).c_str(), durationMs); switch (type) { case Boost::INTERACTION: - if (mVRModeOn || mSustainedPerfModeOn) { + if (mSustainedPerfModeOn) { break; } mInteractionHandler->Acquire(durationMs); @@ -185,12 +137,8 @@ ndk::ScopedAStatus Power::setBoost(Boost type, int32_t durationMs) { [[fallthrough]]; case Boost::AUDIO_LAUNCH: [[fallthrough]]; - case Boost::CAMERA_LAUNCH: - [[fallthrough]]; - case Boost::CAMERA_SHOT: - [[fallthrough]]; default: - if (mVRModeOn || mSustainedPerfModeOn) { + if (mSustainedPerfModeOn) { break; } if (durationMs > 0) { @@ -220,9 +168,8 @@ constexpr const char *boolToString(bool b) { binder_status_t Power::dump(int fd, const char **, uint32_t) { std::string buf(::android::base::StringPrintf( "HintManager Running: %s\n" - "VRMode: %s\n" "SustainedPerformanceMode: %s\n", - boolToString(mHintManager->IsRunning()), boolToString(mVRModeOn), + boolToString(mHintManager->IsRunning()), boolToString(mSustainedPerfModeOn))); // Dump nodes through libperfmgr mHintManager->DumpToFd(fd); diff --git a/power-libperfmgr/Power.h b/power-libperfmgr/Power.h index 04e16d6..0eb7fb4 100644 --- a/power-libperfmgr/Power.h +++ b/power-libperfmgr/Power.h @@ -49,7 +49,6 @@ class Power : public ::aidl::android::hardware::power::BnPower { private: std::shared_ptr mHintManager; std::unique_ptr mInteractionHandler; - std::atomic mVRModeOn; std::atomic mSustainedPerfModeOn; };