BOBtheBlinker/android_device_motorola_sm6375-common
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sm6375-common: power-libperfmgr: Adpf: honor window setting for P,D caculation

Browse source 
Also change default window setting to 0

Bug: 191409203
Test: Build
Signed-off-by: Wei Wang <wvw@google.com>
Change-Id: Ieadf50a64e795d9942373c411189adf9daaee779
This commit is contained in:
Wei Wang 2024-07-18 20:16:00 +05:30 committed by Anand S
parent e5e88cf477
commit d955e9499b
No known key found for this signature in database
GPG key ID: 3B2983FA448B3D61
1 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
power-libperfmgr/PowerHintSession.cpp
View file

@ -137,7 +137,7 @@ static const uint32_t sUclampGranularity =
static const int64_t sStaleTimeFactor = static const int64_t sStaleTimeFactor =
::android::base::GetIntProperty<int64_t>(kPowerHalAdpfStaleTimeFactor, 20); ::android::base::GetIntProperty<int64_t>(kPowerHalAdpfStaleTimeFactor, 20);
static const size_t sSamplingWindow = static const size_t sSamplingWindow =
::android::base::GetUintProperty<size_t>(kPowerHalAdpfSamplingWindow, 1); ::android::base::GetUintProperty<size_t>(kPowerHalAdpfSamplingWindow, 0);
} // namespace } // namespace
@ -303,8 +303,8 @@ ndk::ScopedAStatus PowerHintSession::reportActualWorkDuration(
size_t length = actualDurations.size(); size_t length = actualDurations.size();
size_t start = sSamplingWindow == 0 || sSamplingWindow > length ? 0 : length - sSamplingWindow; size_t start = sSamplingWindow == 0 || sSamplingWindow > length ? 0 : length - sSamplingWindow;
int64_t dt = ns_to_100us(targetDurationNanos); int64_t dt = ns_to_100us(targetDurationNanos);
int64_t error = 0; int64_t err_sum = 0;
int64_t derivative = 0; int64_t derivative_sum = 0;
for (size_t i = start; i < length; i++) { for (size_t i = start; i < length; i++) {
int64_t actualDurationNanos = actualDurations[i].durationNanos; int64_t actualDurationNanos = actualDurations[i].durationNanos;
if (std::abs(actualDurationNanos) > targetDurationNanos * 20) { if (std::abs(actualDurationNanos) > targetDurationNanos * 20) {
@ -312,13 +312,14 @@ ndk::ScopedAStatus PowerHintSession::reportActualWorkDuration(
actualDurationNanos, targetDurationNanos); actualDurationNanos, targetDurationNanos);
} }
// PID control algorithm // PID control algorithm
error = ns_to_100us(actualDurationNanos - targetDurationNanos) + int64_t error = ns_to_100us(actualDurationNanos - targetDurationNanos) +
static_cast<int64_t>(sPidOffset); static_cast<int64_t>(sPidOffset);
derivative_sum += error - mDescriptor->previous_error;
err_sum += error;
mDescriptor->previous_error = error;
mDescriptor->integral_error = mDescriptor->integral_error + error * dt; mDescriptor->integral_error = mDescriptor->integral_error + error * dt;
mDescriptor->integral_error = std::min(sPidIClamp, mDescriptor->integral_error); mDescriptor->integral_error = std::min(sPidIClamp, mDescriptor->integral_error);
mDescriptor->integral_error = std::max(-sPidIClamp, mDescriptor->integral_error); mDescriptor->integral_error = std::max(-sPidIClamp, mDescriptor->integral_error);
derivative = (error - mDescriptor->previous_error) / dt;
mDescriptor->previous_error = error;
} }
if (ATRACE_ENABLED()) { if (ATRACE_ENABLED()) {
std::string sz = StringPrintf("adpf.%" PRId32 "-%" PRId32 "-%" PRIxPTR "-actl_last", std::string sz = StringPrintf("adpf.%" PRId32 "-%" PRId32 "-%" PRIxPTR "-actl_last",
@ -333,14 +334,15 @@ ndk::ScopedAStatus PowerHintSession::reportActualWorkDuration(
reinterpret_cast<uintptr_t>(this) & 0xffff); reinterpret_cast<uintptr_t>(this) & 0xffff);
ATRACE_INT(sz.c_str(), length); ATRACE_INT(sz.c_str(), length);
} }
int64_t pOut = static_cast<int64_t>(sPidP * error); int64_t pOut = static_cast<int64_t>(sPidP * err_sum / (length - start));
int64_t iOut = static_cast<int64_t>(sPidI * mDescriptor->integral_error); int64_t iOut = static_cast<int64_t>(sPidI * mDescriptor->integral_error);
int64_t dOut = static_cast<int64_t>(sPidD * derivative); int64_t dOut = static_cast<int64_t>(sPidD * derivative_sum / dt / (length - start));
int64_t output = pOut + iOut + dOut; int64_t output = pOut + iOut + dOut;
TRACE_ADPF_PID(reinterpret_cast<uintptr_t>(this) & 0xffff, mDescriptor->uid, mDescriptor->tgid, TRACE_ADPF_PID(reinterpret_cast<uintptr_t>(this) & 0xffff, mDescriptor->uid, mDescriptor->tgid,
mDescriptor->update_count, error, mDescriptor->integral_error, derivative, pOut, mDescriptor->update_count, err_sum / (length - start),
iOut, dOut, static_cast<int>(output)); mDescriptor->integral_error, derivative_sum / dt / (length - start), pOut, iOut,
dOut, static_cast<int>(output));
mDescriptor->update_count++; mDescriptor->update_count++;
mStaleHandler->updateStaleTimer(); mStaleHandler->updateStaleTimer();