From 0e782407a59e4a861770bee16ee62549bc21aa42 Mon Sep 17 00:00:00 2001 From: LuK1337 Date: Tue, 23 Jun 2020 14:47:37 +0200 Subject: [PATCH] sm8250-common: power: Fix warnings --- power/power-common.c | 7 +++++-- power/powerhintparser.c | 3 ++- power/utils.c | 4 ++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/power/power-common.c b/power/power-common.c index 0101bea..56f12f4 100644 --- a/power/power-common.c +++ b/power/power-common.c @@ -101,13 +101,16 @@ void power_hint(power_hint_t hint, void *data) handles[hint].ref_count++; } else - if (handles[hint].handle > 0) + if (handles[hint].handle > 0) { if (--handles[hint].ref_count == 0) { release_request(handles[hint].handle); handles[hint].handle = 0; } - else + } else { ALOGE("Lock for hint: %X was not acquired, cannot be released", hint); + } + break; + default: break; } } diff --git a/power/powerhintparser.c b/power/powerhintparser.c index 6d8646f..852c8e6 100644 --- a/power/powerhintparser.c +++ b/power/powerhintparser.c @@ -26,6 +26,8 @@ * IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * */ +#define LOG_TAG "QTI PowerHAL" + #include #include #include @@ -34,7 +36,6 @@ #include #include #include "powerhintparser.h" -#define LOG_TAG "QTI PowerHAL" int parsePowerhintXML() { diff --git a/power/utils.c b/power/utils.c index f7f2251..7fcbd00 100644 --- a/power/utils.c +++ b/power/utils.c @@ -215,7 +215,7 @@ void interaction(int duration, int num_args, int opt_list[]) #ifdef INTERACTION_BOOST static int lock_handle = 0; - if (duration < 0 || num_args < 1 || opt_list[0] == NULL) + if (duration < 0 || num_args < 1 || opt_list[0] == 0) return; if (qcopt_handle) { @@ -230,7 +230,7 @@ void interaction(int duration, int num_args, int opt_list[]) int interaction_with_handle(int lock_handle, int duration, int num_args, int opt_list[]) { - if (duration < 0 || num_args < 1 || opt_list[0] == NULL) + if (duration < 0 || num_args < 1 || opt_list[0] == 0) return 0; if (qcopt_handle) {