From e57d3a223a4ae59b5291e0415b131be5d812b2ec Mon Sep 17 00:00:00 2001 From: alk3pInjection Date: Fri, 14 May 2021 14:05:26 +0800 Subject: [PATCH] sm8250-common: fod: Properly set dim Matches the behavior of stock rom Co-authored-by: Hikari-no-Tenshi Signed-off-by: alk3pInjection Signed-off-by: Omkar Chandorkar Change-Id: I76566f0cf427dcf858fae222e71090ed82eeb710 --- fod/FingerprintInscreen.cpp | 25 ++----------------------- fod/FingerprintInscreen.h | 1 - 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/fod/FingerprintInscreen.cpp b/fod/FingerprintInscreen.cpp index ed318a1..4fe359d 100644 --- a/fod/FingerprintInscreen.cpp +++ b/fod/FingerprintInscreen.cpp @@ -21,7 +21,6 @@ #include #include -#define FINGERPRINT_ERROR_CANCELED 5 #define FINGERPRINT_ACQUIRED_VENDOR 6 #define FINGERPRINT_ERROR_VENDOR 8 @@ -62,13 +61,11 @@ static T get(const std::string& path, const T& def) { FingerprintInscreen::FingerprintInscreen() { this->mFodCircleVisible = false; - this->mIsEnrolling = false; this->mVendorFpService = IVendorFingerprintExtensions::getService(); this->mVendorDisplayService = IOneplusDisplay::getService(); } Return FingerprintInscreen::onStartEnroll() { - this->mIsEnrolling = true; this->mVendorFpService->updateStatus(OP_DISABLE_FP_LONGPRESS); this->mVendorFpService->updateStatus(OP_RESUME_FP_ENROLL); @@ -76,23 +73,18 @@ Return FingerprintInscreen::onStartEnroll() { } Return FingerprintInscreen::onFinishEnroll() { - this->mIsEnrolling = false; this->mVendorFpService->updateStatus(OP_FINISH_FP_ENROLL); return Void(); } Return FingerprintInscreen::onPress() { - if (mIsEnrolling) { - this->mVendorDisplayService->setMode(OP_DISPLAY_SET_DIM, 1); - } this->mVendorDisplayService->setMode(OP_DISPLAY_NOTIFY_PRESS, 1); return Void(); } Return FingerprintInscreen::onRelease() { - this->mVendorDisplayService->setMode(OP_DISPLAY_SET_DIM, 0); this->mVendorDisplayService->setMode(OP_DISPLAY_NOTIFY_PRESS, 0); return Void(); @@ -100,9 +92,7 @@ Return FingerprintInscreen::onRelease() { Return FingerprintInscreen::onShowFODView() { this->mFodCircleVisible = true; - this->mVendorDisplayService->setMode(OP_DISPLAY_AOD_MODE, 0); - this->mVendorDisplayService->setMode(OP_DISPLAY_SET_DIM, 0); - this->mVendorDisplayService->setMode(OP_DISPLAY_NOTIFY_PRESS, 0); + this->mVendorDisplayService->setMode(OP_DISPLAY_SET_DIM, 1); return Void(); } @@ -144,18 +134,7 @@ Return FingerprintInscreen::handleAcquired(int32_t acquiredInfo, int32_t v } Return FingerprintInscreen::handleError(int32_t error, int32_t vendorCode) { - switch (error) { - case FINGERPRINT_ERROR_CANCELED: - if (vendorCode == 0) { - this->mIsEnrolling = false; - } - return false; - case FINGERPRINT_ERROR_VENDOR: - // Ignore vendorCode 6 - return vendorCode == 6; - default: - return false; - } + return error == FINGERPRINT_ERROR_VENDOR && vendorCode == 6; } Return FingerprintInscreen::setLongPressEnabled(bool enabled) { diff --git a/fod/FingerprintInscreen.h b/fod/FingerprintInscreen.h index b322c26..457405c 100644 --- a/fod/FingerprintInscreen.h +++ b/fod/FingerprintInscreen.h @@ -56,7 +56,6 @@ class FingerprintInscreen : public IFingerprintInscreen { private: bool mFodCircleVisible; - bool mIsEnrolling; sp mVendorDisplayService; sp mVendorFpService;