2aca808bc0
Patch Set 1:
(1 comment)
Patch-set: 1
Attention: {"person_ident":"Gerrit User 18745 \u003c18745@1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_18745\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 25732 \u003c25732@1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_18745\u003e replied on the change"}
74 lines
No EOL
2.5 KiB
Text
74 lines
No EOL
2.5 KiB
Text
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d0889ba0_f533100d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 18745
|
|
},
|
|
"writtenOn": "2025-02-14T19:53:32Z",
|
|
"side": 1,
|
|
"message": "Much better fix than keeping saturated color mode",
|
|
"revId": "1756323755dd7fff13e6142d88f85fa2ca3fc0d6",
|
|
"serverId": "1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "852826cd_d302f855",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4550
|
|
},
|
|
"writtenOn": "2025-02-14T23:09:24Z",
|
|
"side": 1,
|
|
"message": "You aren\u0027t supposed to use random qdcm calibration file that\u0027s not even written for your display panel, am I missing something?",
|
|
"revId": "1756323755dd7fff13e6142d88f85fa2ca3fc0d6",
|
|
"serverId": "1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2fc17e65_ded69dec",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 25732
|
|
},
|
|
"writtenOn": "2025-02-14T23:21:55Z",
|
|
"side": 1,
|
|
"message": "That\u0027s correct, those aren\u0027t even applied given it must match your panel name\n\nYou\u0027re basically breaking everything that doesn\u0027t use the native colorspace, so DCI-P3 and HDR content",
|
|
"parentUuid": "852826cd_d302f855",
|
|
"revId": "1756323755dd7fff13e6142d88f85fa2ca3fc0d6",
|
|
"serverId": "1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2cb4b6a9_0559e95a",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 18745
|
|
},
|
|
"writtenOn": "2025-02-15T00:36:40Z",
|
|
"side": 1,
|
|
"message": "Neither DCI-P3 nor HDR are supported by this device, and it doesn\u0027t seem to support sRGB properly, so forcing native colorspace is the whole point.\n\nThe data being imported here is for nt36672e, but it should be \"close enough\" to what dre uses (nt36672c) that it\u0027s not going to make a difference. Just in case, I will try modifying the oplus calibration data and see if that\u0027s a better fix.",
|
|
"parentUuid": "2fc17e65_ded69dec",
|
|
"revId": "1756323755dd7fff13e6142d88f85fa2ca3fc0d6",
|
|
"serverId": "1ec6b3db-b2c1-4fa4-84a2-4c7efe89ba71"
|
|
}
|
|
]
|
|
} |