From 4cc1f3808b4a3425b9897ef2fe2ff2621c4a4b8f Mon Sep 17 00:00:00 2001 From: Yu Tian Date: Mon, 7 Sep 2020 15:30:31 +0800 Subject: [PATCH] qcacld-3.0: Fix memory leak for IPA config allocation Memory allocated in ipa_config_mem_alloc during wlan startup, but it is not freed in error handler path. Add ipa config free in error handler path. Change-Id: Icc86a9c65220f86897481107e8d81cfd87058fa2 CRs-Fixed: 2770385 --- core/hdd/src/wlan_hdd_main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/core/hdd/src/wlan_hdd_main.c b/core/hdd/src/wlan_hdd_main.c index 6b35ef8dd901..4dc896e870f0 100644 --- a/core/hdd/src/wlan_hdd_main.c +++ b/core/hdd/src/wlan_hdd_main.c @@ -3896,14 +3896,14 @@ int hdd_wlan_start_modules(struct hdd_context *hdd_ctx, bool reinit) hdd_err("Failed to Open legacy components; status: %d", status); ret = qdf_status_to_os_return(status); - goto cds_free; + goto ipa_component_free; } ret = hdd_update_config(hdd_ctx); if (ret) { hdd_err("Failed to update configuration; errno: %d", ret); - goto cds_free; + goto ipa_component_free; } status = wbuff_module_init(); @@ -4070,6 +4070,9 @@ psoc_close: wlan_global_lmac_if_close(hdd_ctx->psoc); cds_deinit_ini_config(); +ipa_component_free: + ucfg_ipa_component_config_free(); + cds_free: ol_cds_free();