A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-28 10:41:38 -04:00
Code Issues Projects Releases Packages Wiki Activity

mfd: Fix off-by-one value range checking for tps65910_i2c_write

Browse source 
If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).

Signed-off-by: Axel Lin <[email protected]>
Acked-by: Samuel Ortiz <[email protected]>
Signed-off-by: Liam Girdwood <[email protected]>
This commit is contained in:
Axel Lin 2011-05-16 22:19:01 +08:00 • committed by Liam Girdwood
commit 0514e9acd7
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/mfd/tps65910.c
View file

@ -71,7 +71,7 @@ static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
u8 msg[TPS65910_MAX_REGISTER + 1];
int ret;
if (bytes > (TPS65910_MAX_REGISTER + 1))
if (bytes > TPS65910_MAX_REGISTER)
return -EINVAL;
msg[0] = reg;