From 07025f5ba55f12f86b07f33ef5ea6089bddebc6e Mon Sep 17 00:00:00 2001 From: Jack Pham Date: Wed, 27 Oct 2021 22:48:36 -0700 Subject: [PATCH] usb: pd: Do not respond to SVDM messages in PD 2.0 Since our device does not support responding to Structured VDMs (VIF Responds_to_Discov_SOP_DFP and Responds_to_Discov_SOP_UFP fields are both false), any initiated discovery messages must simply be ignored rather than responding with a NAK. This addresses test failures observed in TEST.PD.VDM.SRC.1, TEST.PD.VDM.SRC.2, TEST.PD.VDM.SNK.1, TEST.PD.VDM.SNK.2, and TEST.PD.VDM.SNK.5 of the USB PD Merged tests. Change-Id: I70f97563e528e4cf6d2a3bce31af7a7c702d4824 Signed-off-by: Jack Pham --- drivers/usb/pd/policy_engine.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/usb/pd/policy_engine.c b/drivers/usb/pd/policy_engine.c index 5f43d3efff78..f1b1ed9c2362 100644 --- a/drivers/usb/pd/policy_engine.c +++ b/drivers/usb/pd/policy_engine.c @@ -1634,11 +1634,6 @@ static void handle_vdm_rx(struct usbpd *pd, struct rx_msg *rx_msg) 0, SOP_MSG); if (ret) usbpd_set_state(pd, PE_SEND_SOFT_RESET); - } else { - usbpd_send_svdm(pd, svid, cmd, - SVDM_CMD_TYPE_RESP_NAK, - SVDM_HDR_OBJ_POS(vdm_hdr), - NULL, 0); } } break;