From 0818b326b100810e72990878bbd1b14d1569fcc3 Mon Sep 17 00:00:00 2001 From: Jianmin Zhu Date: Wed, 4 Jul 2018 11:39:49 +0800 Subject: [PATCH] qcacmn: Enable firmware dump when kernel panic for Rome Firmware dump is necessary to debug host panic issues because host and firmware are out of sync. MACRO DEBUG is undefined by default, after remove it, hif_crash_shutdown->ol_copy_ramdump is called to collect firmware dump. Since dump depend on functions in bmi, add MACRO WLAN_FEATURE_BMI check. TargetFailure event wont't be received after inject assert due to irqs disabled, so can't set target RESET state which is checked when dump IRAM Change-Id: Ia75f5032a2817e35e4c7e777857b137ba3998ebd CRs-Fixed: 2682677 --- hif/src/hif_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hif/src/hif_main.c b/hif/src/hif_main.c index 10aeb4db200b..0b55d79491c5 100644 --- a/hif/src/hif_main.c +++ b/hif/src/hif_main.c @@ -955,8 +955,7 @@ void hif_clear_stats(struct hif_opaque_softc *hif_ctx) * * Return: n/a */ -#if defined(TARGET_RAMDUMP_AFTER_KERNEL_PANIC) \ -&& defined(DEBUG) +#if defined(TARGET_RAMDUMP_AFTER_KERNEL_PANIC) && defined(WLAN_FEATURE_BMI) static void hif_crash_shutdown_dump_bus_register(void *hif_ctx) { @@ -1003,6 +1002,7 @@ void hif_crash_shutdown(struct hif_opaque_softc *hif_ctx) } hif_crash_shutdown_dump_bus_register(hif_ctx); + hif_set_target_status(hif_ctx, TARGET_STATUS_RESET); if (ol_copy_ramdump(hif_ctx)) goto out;