locks: fix leaks on setlease errors

We're depending on setlease to free the passed-in lease on failure.

Signed-off-by: J. Bruce Fields <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
J. Bruce Fields 2010-10-30 17:31:14 -04:00 • committed by Linus Torvalds
commit 096657b65e

View file

@ -1371,20 +1371,22 @@ int generic_setlease(struct file *filp, long arg, struct file_lock **flp)
struct inode *inode = dentry->d_inode;
int error, rdlease_count = 0, wrlease_count = 0;
lease = *flp;
error = -EACCES;
if ((current_fsuid() != inode->i_uid) && !capable(CAP_LEASE))
return -EACCES;
goto out;
error = -EINVAL;
if (!S_ISREG(inode->i_mode))
return -EINVAL;
goto out;
error = security_file_lock(filp, arg);
if (error)
return error;
goto out;
time_out_leases(inode);
BUG_ON(!(*flp)->fl_lmops->fl_break);
lease = *flp;
if (arg != F_UNLCK) {
error = -EAGAIN;
if ((arg == F_RDLCK) && (atomic_read(&inode->i_writecount) > 0))