From 099671a8525ef949cfdbac388ce39c014f5fe0b3 Mon Sep 17 00:00:00 2001 From: Sravan Kumar Kairam Date: Thu, 13 Dec 2018 18:34:07 +0530 Subject: [PATCH] qcacmn: Fix NULL pointer dereference In dp_rx_mon_status_buffers_replenish after replenish of all mon status ring rx buffers there is log in which function local desc list is accessed. But after successful replenish of all the available free desc, free desc list will be NULL. So accessing the free desc list in the debug log leads to NULL pointer dereference. In this change remove the debug log as before that enough logging is in place to check how many buffers are replenished. Change-Id: I306aa52f6f25d9b43afb8548b8c03467aa9f27de CRs-Fixed: 2366585 --- dp/wifi3.0/dp_rx_mon_status.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/dp/wifi3.0/dp_rx_mon_status.c b/dp/wifi3.0/dp_rx_mon_status.c index 90630b56b3f4..7333982eb5ca 100644 --- a/dp/wifi3.0/dp_rx_mon_status.c +++ b/dp/wifi3.0/dp_rx_mon_status.c @@ -953,11 +953,6 @@ QDF_STATUS dp_rx_mon_status_buffers_replenish(struct dp_soc *dp_soc, QDF_TRACE(QDF_MODULE_ID_DP, QDF_TRACE_LEVEL_DEBUG, "%d rx desc added back to free list", num_desc_to_free); - QDF_TRACE(QDF_MODULE_ID_DP, QDF_TRACE_LEVEL_DEBUG, - "[%s][%d] desc_list=%pK, tail=%pK rx_desc=%pK, cookie=%d", - __func__, __LINE__, desc_list, tail, &(*desc_list)->rx_desc, - (*desc_list)->rx_desc.cookie); - /* * add any available free desc back to the free list */