From 0a7b1a142c6b402669ddee0ba0b7940ca1f0586d Mon Sep 17 00:00:00 2001 From: spuligil Date: Tue, 13 Feb 2018 09:01:22 -0800 Subject: [PATCH] fw-api: CL 4166258 - update fw common interface files Change-Id: I25653903406122eb4544932324875aea07d5cd4d WMI: Fix placement of WMI_PEER_OPER_MODE_CHANGE_EVENTID CRs-Fixed: 1107600 --- fw/wmi_unified.h | 41 +++++++++++++++++++++++++++++++++++++++-- fw/wmi_version.h | 2 +- 2 files changed, 40 insertions(+), 3 deletions(-) diff --git a/fw/wmi_unified.h b/fw/wmi_unified.h index 84b5b9e04e9a..d7894b35b97f 100644 --- a/fw/wmi_unified.h +++ b/fw/wmi_unified.h @@ -502,8 +502,19 @@ typedef enum { WMI_PEER_SET_RX_BLOCKSIZE_CMDID, /** request peer antdiv info from FW. FW shall respond with PEER_ANTDIV_INFO_EVENTID */ WMI_PEER_ANTDIV_INFO_REQ_CMDID, - /** Peer operating mode change indication sent to host to update stats */ - WMI_PEER_OPER_MODE_CHANGE_EVENTID, + /* + * The WMI_PEER_OPER_MODE_CHANGE_EVENTID def was originally mistakenly + * placed here, amongst the CMDID defs. + * The WMI_PEER_OPER_MODE_CHANGE_EVENTID def has been moved to the + * EVENTID section, but to preserve backwards compatibility, the value + * here that had been used for WMI_PEER_OPER_MODE_CHANGE_EVENTID + * is kept reserved/deprecated. + * + * This WMI_PEER_RESERVED0_CMDID value can be replaced with an actual + * WMI peer event message ID, though it will be simpler to instead add + * new WMI_PEER CMDID defs at the end of the WMI_GRP_PEER WMI_CMD_GRP. + */ + WMI_PEER_RESERVED0_CMDID, /** Peer/Tid/Msduq threshold update */ WMI_PEER_TID_MSDUQ_QDEPTH_THRESH_UPDATE_CMDID, @@ -1271,6 +1282,32 @@ typedef enum { /** Peer Ant Div Info Event with rssi per chain, etc */ WMI_PEER_ANTDIV_INFO_EVENTID, + /* + * WMI_PEER_RESERVED_EVENTID + * These values are used for placeholders, to allow the subsequent + * WMI_PEER_OPER_MODE_CHANGE_EVENTID constant to have the same value + * as it had in its original location, when it was mistakenly placed + * amongst the WMI_PEER CMDID defs. + * + * These WMI_PEER_RESERVED values can be replaced with actual WMI peer + * event message IDs, though it will be simpler to instead add new + * WMI_PEER EVENTID defs at the end of the WMI_GRP_PEER WMI_EVT_GRP. + */ + WMI_PEER_RESERVED0_EVENTID, + WMI_PEER_RESERVED1_EVENTID, + WMI_PEER_RESERVED2_EVENTID, + WMI_PEER_RESERVED3_EVENTID, + WMI_PEER_RESERVED4_EVENTID, + WMI_PEER_RESERVED5_EVENTID, + WMI_PEER_RESERVED6_EVENTID, + WMI_PEER_RESERVED7_EVENTID, + WMI_PEER_RESERVED8_EVENTID, + WMI_PEER_RESERVED9_EVENTID, + WMI_PEER_RESERVED10_EVENTID, + /** Peer operating mode change indication sent to host to update stats */ + WMI_PEER_OPER_MODE_CHANGE_EVENTID, + + /* beacon/mgmt specific events */ /** RX management frame. the entire frame is carried along with the event. */ WMI_MGMT_RX_EVENTID = WMI_EVT_GRP_START_ID(WMI_GRP_MGMT), diff --git a/fw/wmi_version.h b/fw/wmi_version.h index 805aa24fe8c7..09ed3ae2b287 100644 --- a/fw/wmi_version.h +++ b/fw/wmi_version.h @@ -36,7 +36,7 @@ #define __WMI_VER_MINOR_ 0 /** WMI revision number has to be incremented when there is a * change that may or may not break compatibility. */ -#define __WMI_REVISION_ 504 +#define __WMI_REVISION_ 505 /** The Version Namespace should not be normally changed. Only * host and firmware of the same WMI namespace will work