From 0b8376adfad89c083c666b85a2e125ac7d6473cc Mon Sep 17 00:00:00 2001 From: Priyansh Jain Date: Fri, 13 Aug 2021 10:48:16 +0530 Subject: [PATCH] drivers: thermal: tsens: Optimize logs in tsens crash path Logs loop count is reduced from 5 to 1 as 5 time looping of same register set is not required. Change-Id: Iba5b4b39c2cebb19298250925ea01992ddcd5e77 Signed-off-by: Priyansh Jain --- drivers/thermal/tsens-dbg.c | 33 ++++++++++++++------------------- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/thermal/tsens-dbg.c b/drivers/thermal/tsens-dbg.c index 26922b43f16b..e4ed076566b9 100644 --- a/drivers/thermal/tsens-dbg.c +++ b/drivers/thermal/tsens-dbg.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * Copyright (c) 2017-2020, The Linux Foundation. All rights reserved. + * Copyright (c) 2017-2021, The Linux Foundation. All rights reserved. */ #include @@ -371,28 +371,23 @@ static int tsens_dbg_log_bus_id_data(struct tsens_device *data, offset += TSENS_DEBUG_OFFSET_ROW; } - loop = 0; - while (loop < TSENS_DEBUG_LOOP_COUNT) { - offset = TSENS_DEBUG_OFFSET_ROW * - TSENS_DEBUG_STATUS_REG_START; - TSENS_DUMP(tmdev, "Start of TSENS TM dump %d\n", - loop); - /* Limited dump of the registers for the temperature */ - for (i = 0; i < TSENS_DEBUG_LOOP_COUNT; i++) { - r1 = readl_relaxed(controller_id_addr + offset); - r2 = readl_relaxed(controller_id_addr + - (offset + TSENS_DEBUG_OFFSET_WORD1)); - r3 = readl_relaxed(controller_id_addr + - (offset + TSENS_DEBUG_OFFSET_WORD2)); - r4 = readl_relaxed(controller_id_addr + - (offset + TSENS_DEBUG_OFFSET_WORD3)); + offset = TSENS_DEBUG_OFFSET_ROW * + TSENS_DEBUG_STATUS_REG_START; + TSENS_DUMP(tmdev, "%s", "Start of TSENS TM dump\n"); + /* Limited dump of the registers for the temperature */ + for (i = 0; i < TSENS_DEBUG_LOOP_COUNT; i++) { + r1 = readl_relaxed(controller_id_addr + offset); + r2 = readl_relaxed(controller_id_addr + + (offset + TSENS_DEBUG_OFFSET_WORD1)); + r3 = readl_relaxed(controller_id_addr + + (offset + TSENS_DEBUG_OFFSET_WORD2)); + r4 = readl_relaxed(controller_id_addr + + (offset + TSENS_DEBUG_OFFSET_WORD3)); TSENS_DUMP(tmdev, "ctrl:%d:0x%08x 0x%08x 0x%08x 0x%08x 0x%08x\n", cntrl_id, offset, r1, r2, r3, r4); - offset += TSENS_DEBUG_OFFSET_ROW; - } - loop++; + offset += TSENS_DEBUG_OFFSET_ROW; } return 0;