From 0ba9663f16e7720efbadb95727d4fe7ad4d7dacc Mon Sep 17 00:00:00 2001 From: Sudarshan Rajagopalan Date: Wed, 11 Sep 2019 23:54:09 -0700 Subject: [PATCH] ion: remove cpu binding of pool refill kthreads Remove the cpu affinity of ion pool refill kthreads which were binded to min capability cpus, since there was no observable power impact with when not affined. Note: It was found that the code to create cpumask for min capability cpus was broken and kthreads were free to run on any cpus. No observable power impact was seen, hence better off with removing this code entirely. Change-Id: If6a32d9e4d3c576e63e3b0ec405be1fd4639a5e0 Signed-off-by: Sudarshan Rajagopalan Signed-off-by: Isaac J. Manjarres --- drivers/staging/android/ion/heaps/ion_system_heap.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/android/ion/heaps/ion_system_heap.c b/drivers/staging/android/ion/heaps/ion_system_heap.c index dc3093845e86..917f3cc8f27b 100644 --- a/drivers/staging/android/ion/heaps/ion_system_heap.c +++ b/drivers/staging/android/ion/heaps/ion_system_heap.c @@ -679,17 +679,9 @@ static struct task_struct *ion_create_kworker(struct ion_page_pool **pools, struct task_struct *thread; int ret; char *buf; - cpumask_t *cpumask; - DECLARE_BITMAP(bmap, nr_cpumask_bits); attr.sched_nice = ION_KTHREAD_NICE_VAL; buf = cached ? "cached" : "uncached"; - /* - * Affine the kthreads to min capacity CPUs - * TODO: remove this hack once is_min_capability_cpu is available - */ - bitmap_fill(bmap, 0x4); - cpumask = to_cpumask(bmap); thread = kthread_create(ion_sys_heap_worker, pools, "ion-pool-%s-worker", buf); @@ -705,7 +697,7 @@ static struct task_struct *ion_create_kworker(struct ion_page_pool **pools, __func__, buf, ret); return ERR_PTR(ret); } - kthread_bind_mask(thread, cpumask); + return thread; }