A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-10 06:09:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Refactor RSN_IE configuration

Browse source 
One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.

As part of that goal refactor the following independent attribute
handling into a separate function and add that function to the vtable:
- QCA_WLAN_VENDOR_ATTR_CONFIG_RSN_IE

Change-Id: Ib513fce2a797a31fe9c81bcc3e142b61db972d30
CRs-Fixed: 2371587
This commit is contained in:
Jeff Johnson 2018-11-16 11:42:10 -08:00
commit 0bdbb96857
1 changed files with 26 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

43
core/hdd/src/wlan_hdd_cfg80211.c
View file

@ -6175,6 +6175,30 @@ static int hdd_config_disable_fils(struct hdd_adapter *adapter,
return qdf_status_to_os_return(status);
}
static int hdd_config_rsn_ie(struct hdd_adapter *adapter,
const struct nlattr *attr)
{
struct hdd_context *hdd_ctx = WLAN_HDD_GET_CTX(adapter);
bool override_enabled;
uint8_t force_rsne_override;
/* ignore unless support explicitly enabled */
ucfg_mlme_get_force_rsne_override(hdd_ctx->psoc, &override_enabled);
if (!override_enabled)
return 0;
force_rsne_override = nla_get_u8(attr);
if (force_rsne_override > 1) {
hdd_err("Invalid value %d", force_rsne_override);
return -EINVAL;
}
hdd_ctx->force_rsne_override = force_rsne_override;
hdd_debug("force_rsne_override - %d", force_rsne_override);
return 0;
}
/**
* typedef independent_setter_fn - independent attribute handler
* @adapter: The adapter being configured
@ -6255,6 +6279,8 @@ static const struct independent_setters independent_setters[] = {
hdd_config_latency_level},
{QCA_WLAN_VENDOR_ATTR_CONFIG_DISABLE_FILS,
hdd_config_disable_fils},
{QCA_WLAN_VENDOR_ATTR_CONFIG_RSN_IE,
hdd_config_rsn_ie},
};
/**
@ -6377,7 +6403,6 @@ __wlan_hdd_cfg80211_wifi_configuration_set(struct wiphy *wiphy,
QDF_STATUS qdf_status;
uint32_t ant_div_usrcfg;
mac_handle_t mac_handle;
bool b_value;
hdd_enter_dev(dev);
qdf_mem_zero(&request, sizeof(request));
@ -6551,22 +6576,6 @@ __wlan_hdd_cfg80211_wifi_configuration_set(struct wiphy *wiphy,
if (ret_val != 0)
return ret_val;
ucfg_mlme_get_force_rsne_override(hdd_ctx->psoc, &b_value);
if (tb[QCA_WLAN_VENDOR_ATTR_CONFIG_RSN_IE] && b_value) {
uint8_t force_rsne_override;
force_rsne_override =
nla_get_u8(tb[QCA_WLAN_VENDOR_ATTR_CONFIG_RSN_IE]);
if (force_rsne_override > 1) {
hdd_err("Invalid test_mode %d", force_rsne_override);
ret_val = -EINVAL;
}
hdd_ctx->force_rsne_override = force_rsne_override;
hdd_debug("force_rsne_override - %d",
hdd_ctx->force_rsne_override);
}
if (tb[QCA_WLAN_VENDOR_ATTR_CONFIG_GTX]) {
uint8_t config_gtx;