From 0c751e27f7897e30140e2208d7489eb7f7405224 Mon Sep 17 00:00:00 2001 From: Jeff Johnson Date: Tue, 29 Aug 2017 14:15:25 -0700 Subject: [PATCH] qcacld-3.0: Replace hdd_adapter_t in wlan_hdd_wowl.[ch] The Linux Coding Style enumerates a few special cases where typedefs are useful, but stresses "NEVER EVER use a typedef unless you can clearly match one of those rules." The hdd_adapter_t typedef does not meet any of those criteria, so replace references to it with a reference to the underlying struct. Change-Id: I322b521f70e7b7b17b9dc1b0cf716f84722ca6e0 CRs-Fixed: 2101025 --- core/hdd/inc/wlan_hdd_wowl.h | 12 ++++++------ core/hdd/src/wlan_hdd_wowl.c | 14 +++++++------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/core/hdd/inc/wlan_hdd_wowl.h b/core/hdd/inc/wlan_hdd_wowl.h index 4697e74c95f9..a41385675848 100644 --- a/core/hdd/inc/wlan_hdd_wowl.h +++ b/core/hdd/inc/wlan_hdd_wowl.h @@ -116,7 +116,7 @@ * * Return: false if any errors encountered, true otherwise */ -bool hdd_add_wowl_ptrn(hdd_adapter_t *pAdapter, const char *ptrn); +bool hdd_add_wowl_ptrn(struct hdd_adapter *pAdapter, const char *ptrn); /** * hdd_del_wowl_ptrn() - Function which will remove a WoWL pattern @@ -125,7 +125,7 @@ bool hdd_add_wowl_ptrn(hdd_adapter_t *pAdapter, const char *ptrn); * * Return: false if any errors encountered, true otherwise */ -bool hdd_del_wowl_ptrn(hdd_adapter_t *pAdapter, const char *ptrn); +bool hdd_del_wowl_ptrn(struct hdd_adapter *pAdapter, const char *ptrn); /** * hdd_add_wowl_ptrn_debugfs() - Function which will add a WoW pattern @@ -138,7 +138,7 @@ bool hdd_del_wowl_ptrn(hdd_adapter_t *pAdapter, const char *ptrn); * * Return: false if any errors encountered, true otherwise */ -bool hdd_add_wowl_ptrn_debugfs(hdd_adapter_t *pAdapter, uint8_t pattern_idx, +bool hdd_add_wowl_ptrn_debugfs(struct hdd_adapter *pAdapter, uint8_t pattern_idx, uint8_t pattern_offset, char *pattern_buf, char *pattern_mask); @@ -150,7 +150,7 @@ bool hdd_add_wowl_ptrn_debugfs(hdd_adapter_t *pAdapter, uint8_t pattern_idx, * * Return: false if any errors encountered, true otherwise */ -bool hdd_del_wowl_ptrn_debugfs(hdd_adapter_t *pAdapter, uint8_t pattern_idx); +bool hdd_del_wowl_ptrn_debugfs(struct hdd_adapter *pAdapter, uint8_t pattern_idx); /** * hdd_enter_wowl() - Function which will enable WoWL. At least one @@ -161,7 +161,7 @@ bool hdd_del_wowl_ptrn_debugfs(hdd_adapter_t *pAdapter, uint8_t pattern_idx); * * Return: false if any errors encountered, true otherwise */ -bool hdd_enter_wowl(hdd_adapter_t *pAdapter, bool enable_mp, bool enable_pbm); +bool hdd_enter_wowl(struct hdd_adapter *pAdapter, bool enable_mp, bool enable_pbm); /** * hdd_exit_wowl() - Function which will disable WoWL @@ -169,7 +169,7 @@ bool hdd_enter_wowl(hdd_adapter_t *pAdapter, bool enable_mp, bool enable_pbm); * * Return: false if any errors encountered, true otherwise */ -bool hdd_exit_wowl(hdd_adapter_t *pAdapter); +bool hdd_exit_wowl(struct hdd_adapter *pAdapter); /** * hdd_deinit_wowl() - Deinit function to cleanup WoWL allocated memory diff --git a/core/hdd/src/wlan_hdd_wowl.c b/core/hdd/src/wlan_hdd_wowl.c index de18458371e4..c7eeb578cd16 100644 --- a/core/hdd/src/wlan_hdd_wowl.c +++ b/core/hdd/src/wlan_hdd_wowl.c @@ -67,7 +67,7 @@ static void hdd_wowl_wake_indication_callback(void *pContext, tpSirWakeReasonInd wake_reason_ind) { hdd_info("Wake Reason %d", wake_reason_ind->ulReason); - hdd_exit_wowl((hdd_adapter_t *) pContext); + hdd_exit_wowl((struct hdd_adapter *) pContext); } #endif @@ -101,7 +101,7 @@ static void dump_hdd_wowl_ptrn(struct wow_add_pattern *ptrn) * * Return: false if any errors encountered, true otherwise */ -bool hdd_add_wowl_ptrn(hdd_adapter_t *pAdapter, const char *ptrn) +bool hdd_add_wowl_ptrn(struct hdd_adapter *pAdapter, const char *ptrn) { struct wow_add_pattern localPattern; int i, first_empty_slot, len, offset; @@ -261,7 +261,7 @@ next_ptrn: * * Return: false if any errors encountered, true otherwise */ -bool hdd_del_wowl_ptrn(hdd_adapter_t *pAdapter, const char *ptrn) +bool hdd_del_wowl_ptrn(struct hdd_adapter *pAdapter, const char *ptrn) { struct wow_delete_pattern delPattern; unsigned char id; @@ -312,7 +312,7 @@ bool hdd_del_wowl_ptrn(hdd_adapter_t *pAdapter, const char *ptrn) * * Return: false if any errors encountered, true otherwise */ -bool hdd_add_wowl_ptrn_debugfs(hdd_adapter_t *pAdapter, uint8_t pattern_idx, +bool hdd_add_wowl_ptrn_debugfs(struct hdd_adapter *pAdapter, uint8_t pattern_idx, uint8_t pattern_offset, char *pattern_buf, char *pattern_mask) { @@ -425,7 +425,7 @@ bool hdd_add_wowl_ptrn_debugfs(hdd_adapter_t *pAdapter, uint8_t pattern_idx, * * Return: false if any errors encountered, true otherwise */ -bool hdd_del_wowl_ptrn_debugfs(hdd_adapter_t *pAdapter, uint8_t pattern_idx) +bool hdd_del_wowl_ptrn_debugfs(struct hdd_adapter *pAdapter, uint8_t pattern_idx) { struct wow_delete_pattern delPattern; tHalHandle hHal = WLAN_HDD_GET_HAL_CTX(pAdapter); @@ -473,7 +473,7 @@ bool hdd_del_wowl_ptrn_debugfs(hdd_adapter_t *pAdapter, uint8_t pattern_idx) * * Return: false if any errors encountered, true otherwise */ -bool hdd_enter_wowl(hdd_adapter_t *pAdapter, bool enable_mp, bool enable_pbm) +bool hdd_enter_wowl(struct hdd_adapter *pAdapter, bool enable_mp, bool enable_pbm) { tSirSmeWowlEnterParams wowParams; QDF_STATUS qdf_ret_status; @@ -521,7 +521,7 @@ bool hdd_enter_wowl(hdd_adapter_t *pAdapter, bool enable_mp, bool enable_pbm) * * Return: false if any errors encountered, true otherwise */ -bool hdd_exit_wowl(hdd_adapter_t *pAdapter) +bool hdd_exit_wowl(struct hdd_adapter *pAdapter) { tSirSmeWowlExitParams wowParams; tHalHandle hHal = WLAN_HDD_GET_HAL_CTX(pAdapter);