mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 11:11:45 -04:00
net, sunrpc: convert gss_cl_ctx.count from atomic_t to refcount_t
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova <[email protected]> Signed-off-by: Hans Liljestrand <[email protected]> Signed-off-by: Kees Cook <[email protected]> Signed-off-by: David Windsor <[email protected]> Signed-off-by: David S. Miller <[email protected]>
This commit is contained in:
parent
156be7edc8
commit
0fa104726b
2 changed files with 5 additions and 4 deletions
|
|
@ -117,14 +117,14 @@ static const struct rpc_pipe_ops gss_upcall_ops_v1;
|
|||
static inline struct gss_cl_ctx *
|
||||
gss_get_ctx(struct gss_cl_ctx *ctx)
|
||||
{
|
||||
atomic_inc(&ctx->count);
|
||||
refcount_inc(&ctx->count);
|
||||
return ctx;
|
||||
}
|
||||
|
||||
static inline void
|
||||
gss_put_ctx(struct gss_cl_ctx *ctx)
|
||||
{
|
||||
if (atomic_dec_and_test(&ctx->count))
|
||||
if (refcount_dec_and_test(&ctx->count))
|
||||
gss_free_ctx(ctx);
|
||||
}
|
||||
|
||||
|
|
@ -200,7 +200,7 @@ gss_alloc_context(void)
|
|||
ctx->gc_proc = RPC_GSS_PROC_DATA;
|
||||
ctx->gc_seq = 1; /* NetApp 6.4R1 doesn't accept seq. no. 0 */
|
||||
spin_lock_init(&ctx->gc_seq_lock);
|
||||
atomic_set(&ctx->count,1);
|
||||
refcount_set(&ctx->count,1);
|
||||
}
|
||||
return ctx;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue