From d40224d780c35224b19ab9d9219f4d2217404465 Mon Sep 17 00:00:00 2001 From: Pratham Pratap Date: Thu, 16 Apr 2020 13:20:46 +0530 Subject: [PATCH] usb: gsi: Add NULL pointer check Static code analysis tool is detecting a possible NULL pointer dereference for gsi->d_port.in_ep in the error handling path. This change adds a NULL pointer check to avoid this issue. Change-Id: I4adf03e933cece0698cd3761c8758f4bd98925f4 Signed-off-by: Pratham Pratap --- drivers/usb/gadget/function/f_gsi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/f_gsi.c b/drivers/usb/gadget/function/f_gsi.c index 8c5a2d09f84b..056defd9d60e 100644 --- a/drivers/usb/gadget/function/f_gsi.c +++ b/drivers/usb/gadget/function/f_gsi.c @@ -855,8 +855,10 @@ static int gsi_ep_enable(struct f_gsi *gsi) ret = usb_gsi_ep_op(gsi->d_port.out_ep, &gsi->d_port.out_request, GSI_EP_OP_CONFIG); if (ret) { - usb_gsi_ep_op(gsi->d_port.in_ep, - &gsi->d_port.in_request, GSI_EP_OP_DISABLE); + if (gsi->d_port.in_ep) + usb_gsi_ep_op(gsi->d_port.in_ep, + &gsi->d_port.in_request, + GSI_EP_OP_DISABLE); return ret; } }