mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-28 10:41:38 -04:00
extcon: max14577: Use devm_extcon_dev_register()
Use the resource-managed extcon device register function (i.e. devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon device is attached with this function, that extcon device is automatically unregistered on driver detach. That reduces tiresome managing code. Signed-off-by: Sangjung Woo <[email protected]> Reviewed-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Chanwoo Choi <[email protected]>
This commit is contained in:
parent
d92c2f12f8
commit
14dbd54962
1 changed files with 2 additions and 7 deletions
|
|
@ -747,7 +747,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
|
|||
|
||||
info->edev->name = dev_name(&pdev->dev);
|
||||
info->edev->supported_cable = max14577_extcon_cable;
|
||||
ret = extcon_dev_register(info->edev);
|
||||
ret = devm_extcon_dev_register(&pdev->dev, info->edev);
|
||||
if (ret) {
|
||||
dev_err(&pdev->dev, "failed to register extcon device\n");
|
||||
return ret;
|
||||
|
|
@ -766,7 +766,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
|
|||
MAX14577_REG_DEVICEID, &id);
|
||||
if (ret < 0) {
|
||||
dev_err(&pdev->dev, "failed to read revision number\n");
|
||||
goto err_extcon;
|
||||
return ret;
|
||||
}
|
||||
dev_info(info->dev, "device ID : 0x%x\n", id);
|
||||
|
||||
|
|
@ -786,10 +786,6 @@ static int max14577_muic_probe(struct platform_device *pdev)
|
|||
delay_jiffies);
|
||||
|
||||
return ret;
|
||||
|
||||
err_extcon:
|
||||
extcon_dev_unregister(info->edev);
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int max14577_muic_remove(struct platform_device *pdev)
|
||||
|
|
@ -797,7 +793,6 @@ static int max14577_muic_remove(struct platform_device *pdev)
|
|||
struct max14577_muic_info *info = platform_get_drvdata(pdev);
|
||||
|
||||
cancel_work_sync(&info->irq_work);
|
||||
extcon_dev_unregister(info->edev);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue