From 18617b86385d70312b939704bf15846ef164881f Mon Sep 17 00:00:00 2001 From: Sathish Kumar Date: Wed, 20 Jun 2018 17:57:24 +0530 Subject: [PATCH] qcacmn: Decouple netlink service and wlan logging service Netlink service init and exit is invoked as part of wlan logging init and exit during qdf module init and exit. This brings in a hard dependency to enable and compile wlan logging service even if not used. Decouple netlink service and wlan logging service to remove inter-dependency. WIN qdf module currently does not require wlan logging to be enabled. This separation leads to bss savings in qdf module. Change-Id: Ib0afafd196106eba78ad9783eb1a6cece77c00fa CRs-Fixed: 2258640 --- qdf/Kbuild | 4 ++-- qdf/linux/src/qdf_trace.c | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/qdf/Kbuild b/qdf/Kbuild index 3463afda20e5..e23840e5699c 100644 --- a/qdf/Kbuild +++ b/qdf/Kbuild @@ -48,7 +48,8 @@ linux/src/qdf_file.o \ src/qdf_flex_mem.o \ src/qdf_parse.o \ src/qdf_str.o \ -src/qdf_types.o +src/qdf_types.o \ +$(HOST_CMN_CONVG_NLINK)/src/wlan_nlink_srv.o #linux/src/qdf_net.o \ #linux/src/qdf_net_event.o \ #linux/src/qdf_net_ioctl.o @@ -60,7 +61,6 @@ endif ifeq ($(LOGGING_UTILS_SUPPORT),1) qdf-objs += \ -$(HOST_CMN_CONVG_NLINK)/src/wlan_nlink_srv.o \ $(HOST_CMN_CONVG_LOGGING)/src/wlan_logging_sock_svc.o endif diff --git a/qdf/linux/src/qdf_trace.c b/qdf/linux/src/qdf_trace.c index 5c4ea5cfb1d4..8eebf711e275 100644 --- a/qdf/linux/src/qdf_trace.c +++ b/qdf/linux/src/qdf_trace.c @@ -3368,10 +3368,12 @@ void qdf_logging_exit(void) #else void qdf_logging_init(void) { + nl_srv_init(NULL); } void qdf_logging_exit(void) { + nl_srv_exit(); } #endif