A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-23 21:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Don't set adapter dev to NULL in hostapd unint

Browse source 
With the existing design the panic is seen with the below
scenario.
1) As a part of country change, driver takes the dev_hold and proceed
   with the adapter access.
2) In another thread, del virtual iface is called which calls the
   unregister netdev. This kernel API(unregister netdev) calls the
   hdd_hostapd_unint where the adapter->dev is set to NULL. After
   this  unregister_netdev waits for the dev_put as driver has
   taken the dev_hold in 1). Till this dev_put happens
   unregister_netdev will wait.
3) Once the adapter access is completed as a part of 1), driver
   does the dev_put with the pointer dev which is made as NULL in 2).

To avoid this crash, don't set the adapter->dev to NULL in
hostapd unint.

CRs-Fixed: 2791420
Change-Id: I1f6252a44c061b697c8d640c5558350e91a47442
This commit is contained in:
Sachin Ahuja 2020-10-08 15:47:13 +05:30 • committed by snandini
commit 19cae30b59
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
core/hdd/src/wlan_hdd_hostapd.c
View file

@ -603,7 +603,6 @@ static void hdd_hostapd_uninit(struct net_device *dev)
hdd_deinit_adapter(hdd_ctx, adapter, true);
/* after uninit our adapter structure will no longer be valid */
adapter->dev = NULL;
adapter->magic = 0;
hdd_exit();