A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-09 21:59:12 -04:00
Code Issues Projects Releases Packages Wiki Activity

mailbox: Don't check for NULL before ipc_log_string()

Browse source 
The ipc_log_string() function quietly checks for a NULL context so an
explicit check is not needed.

Also fix the string format for QMP_ERROR so that the same string is
generated for both logging methods.

Change-Id: Ic0dedbad69759a9025b41584d13ed6ca982d2015
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
This commit is contained in:
Jordan Crouse 2019-10-15 09:37:37 -06:00
commit 1b34696d54
1 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

14
drivers/mailbox/msm_qmp.c
View file

@ -34,16 +34,12 @@
#define QMP_IPC_LOG_PAGE_CNT 2
#define QMP_INFO(ctxt, x, ...) \
do { \
if (ctxt) \
ipc_log_string(ctxt, "[%s]: "x, __func__, ##__VA_ARGS__); \
} while (0)
ipc_log_string(ctxt, "[%s]: "x, __func__, ##__VA_ARGS__)
#define QMP_ERR(ctxt, x, ...) \
do { \
pr_err_ratelimited("[%s]: "x, __func__, ##__VA_ARGS__); \
if (ctxt) \
ipc_log_string(ctxt, "[%s]: "x, __func__, ##__VA_ARGS__); \
#define QMP_ERR(ctxt, x, ...) \
do { \
printk_ratelimited("%s[%s]: "x, KERN_ERR, __func__, ##__VA_ARGS__); \
ipc_log_string(ctxt, "%s[%s]: "x, "", __func__, ##__VA_ARGS__); \
} while (0)
/**