A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-09 05:39:54 -04:00
Code Issues Projects Releases Packages Wiki Activity

msm: mhi_dev: Avoiding null pointer dereference in uci layer

Browse source 
Avoiding null pointer dereference in mhi_uci_client_open API in uci layer
by changing the location of the condition check for uci_handle.

Change-Id: If2cc99f47f4c5d05d0df4a5b4900894683f7c8d1
Signed-off-by: Sai Chaitanya Kaveti <quic_skaveti@quicinc.com>
This commit is contained in:
Sai Chaitanya Kaveti 2022-06-21 20:57:43 +05:30 • committed by Gerrit - the friendly Code Review server
commit 1bcfee37cb
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
drivers/platform/msm/mhi_dev/mhi_uci.c
View file

@ -1081,17 +1081,16 @@ static int mhi_uci_client_open(struct inode *mhi_inode,
return -EINVAL;
}
if (!uci_handle) {
uci_log(UCI_DBG_DBG, "No memory, returning failure\n");
return -ENOMEM;
}
mutex_lock(&uci_handle->client_lock);
uci_log(UCI_DBG_DBG,
"Client opened struct device node 0x%x, ref count 0x%x\n",
iminor(mhi_inode), atomic_read(&uci_handle->ref_count));
if (atomic_add_return(1, &uci_handle->ref_count) == 1) {
if (!uci_handle) {
atomic_dec(&uci_handle->ref_count);
uci_log(UCI_DBG_DBG, "No memory, returning failure\n");
mutex_unlock(&uci_handle->client_lock);
return -ENOMEM;
}
uci_handle->uci_ctxt = &uci_ctxt;
uci_handle->f_flags = file_handle->f_flags;
if (!atomic_read(&uci_handle->mhi_chans_open)) {