From 2101268ecea956928c0e34fc92c056f15cf0423a Mon Sep 17 00:00:00 2001 From: Sourav Mohapatra Date: Thu, 24 May 2018 10:53:17 +0530 Subject: [PATCH] qcacld-3.0: Add compile time check for cRegTableEntries The maximum value of the variable cRegTableEntries is defined in MAX_CFG_INI_ITEMS. In the scenario the value is greater than this it may cause an overrun may occur due to the weak guard. Turn the runtime check into compile time check to prevent such scenario. Change-Id: I58a0d47a32d457297d3caa456fd0ca03523ed9f5 CRs-Fixed: 2232723 --- core/hdd/src/wlan_hdd_cfg.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/core/hdd/src/wlan_hdd_cfg.c b/core/hdd/src/wlan_hdd_cfg.c index 450c929d9835..99ca133cfeb1 100644 --- a/core/hdd/src/wlan_hdd_cfg.c +++ b/core/hdd/src/wlan_hdd_cfg.c @@ -5724,11 +5724,7 @@ static QDF_STATUS hdd_apply_cfg_ini(struct hdd_context *hdd_ctx, int i; int rv; - if (MAX_CFG_INI_ITEMS < cRegTableEntries) { - hdd_err("MAX_CFG_INI_ITEMS too small, must be at least %ld", - cRegTableEntries); - WARN_ON(1); - } + BUILD_BUG_ON(MAX_CFG_INI_ITEMS < cRegTableEntries); for (idx = 0; idx < cRegTableEntries; idx++, pRegEntry++) { /* Calculate the address of the destination field in the structure. */