mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 11:11:45 -04:00
userfaultfd: hugetlbfs: reserve count on error in __mcopy_atomic_hugetlb
If __mcopy_atomic_hugetlb exits with an error, put_page will be called if a huge page was allocated and needs to be freed. If a reservation was associated with the huge page, the PagePrivate flag will be set. Clear PagePrivate before calling put_page/free_huge_page so that the global reservation count is not incremented. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Mike Kravetz <[email protected]> Signed-off-by: Andrea Arcangeli <[email protected]> Cc: "Dr. David Alan Gilbert" <[email protected]> Cc: Hillf Danton <[email protected]> Cc: Michael Rapoport <[email protected]> Cc: Mike Rapoport <[email protected]> Cc: Pavel Emelyanov <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
parent
87ffc118b5
commit
21205bf8f7
1 changed files with 16 additions and 1 deletions
|
|
@ -301,8 +301,23 @@ retry:
|
|||
out_unlock:
|
||||
up_read(&dst_mm->mmap_sem);
|
||||
out:
|
||||
if (page)
|
||||
if (page) {
|
||||
/*
|
||||
* We encountered an error and are about to free a newly
|
||||
* allocated huge page. It is possible that there was a
|
||||
* reservation associated with the page that has been
|
||||
* consumed. See the routine restore_reserve_on_error
|
||||
* for details. Unfortunately, we can not call
|
||||
* restore_reserve_on_error now as it would require holding
|
||||
* mmap_sem. Clear the PagePrivate flag so that the global
|
||||
* reserve count will not be incremented in free_huge_page.
|
||||
* The reservation map will still indicate the reservation
|
||||
* was consumed and possibly prevent later page allocation.
|
||||
* This is better than leaking a global reservation.
|
||||
*/
|
||||
ClearPagePrivate(page);
|
||||
put_page(page);
|
||||
}
|
||||
BUG_ON(copied < 0);
|
||||
BUG_ON(err > 0);
|
||||
BUG_ON(!copied && !err);
|
||||
|
|
|
|||
Loading…
Reference in a new issue