mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 19:21:31 -04:00
don't put symlink bodies in pagecache into highmem
kmap() in page_follow_link_light() needed to go - allowing to hold an arbitrary number of kmaps for long is a great way to deadlocking the system. new helper (inode_nohighmem(inode)) needs to be used for pagecache symlinks inodes; done for all in-tree cases. page_follow_link_light() instrumented to yell about anything missed. Signed-off-by: Al Viro <[email protected]>
This commit is contained in:
parent
aa80deab33
commit
21fc61c73c
57 changed files with 81 additions and 46 deletions
|
|
@ -1417,6 +1417,7 @@ static int isofs_read_inode(struct inode *inode, int relocated)
|
|||
inode->i_fop = &isofs_dir_operations;
|
||||
} else if (S_ISLNK(inode->i_mode)) {
|
||||
inode->i_op = &page_symlink_inode_operations;
|
||||
inode_nohighmem(inode);
|
||||
inode->i_data.a_ops = &isofs_symlink_aops;
|
||||
} else
|
||||
/* XXX - parse_rock_ridge_inode() had already set i_rdev. */
|
||||
|
|
|
|||
|
|
@ -687,7 +687,7 @@ static int rock_ridge_symlink_readpage(struct file *file, struct page *page)
|
|||
struct inode *inode = page->mapping->host;
|
||||
struct iso_inode_info *ei = ISOFS_I(inode);
|
||||
struct isofs_sb_info *sbi = ISOFS_SB(inode->i_sb);
|
||||
char *link = kmap(page);
|
||||
char *link = page_address(page);
|
||||
unsigned long bufsize = ISOFS_BUFFER_SIZE(inode);
|
||||
struct buffer_head *bh;
|
||||
char *rpnt = link;
|
||||
|
|
@ -774,7 +774,6 @@ repeat:
|
|||
brelse(bh);
|
||||
*rpnt = '\0';
|
||||
SetPageUptodate(page);
|
||||
kunmap(page);
|
||||
unlock_page(page);
|
||||
return 0;
|
||||
|
||||
|
|
@ -791,7 +790,6 @@ fail:
|
|||
brelse(bh);
|
||||
error:
|
||||
SetPageError(page);
|
||||
kunmap(page);
|
||||
unlock_page(page);
|
||||
return -EIO;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue