A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-31 04:01:48 -04:00
Code Issues Projects Releases Packages Wiki Activity

driver: uio: fix possible use-after-free in __uio_register_device

Browse source 
In uio_dev_add_attributes() error handing case, idev is used after
device_unregister(), in which 'idev' has been released, touch idev cause
use-after-free.

Fixes: a93e7b3315 ("uio: Prevent device destruction while fds are open")
Signed-off-by: Liu Jian <[email protected]>
Reviewed-by: Hamish Martin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit is contained in:
Liu Jian 2019-01-23 06:45:38 +08:00 • committed by Greg Kroah-Hartman
commit 221a1f4ac1
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
drivers/uio/uio.c
View file

@ -945,6 +945,7 @@ int __uio_register_device(struct module *owner,
return ret;
}
device_initialize(&idev->dev);
idev->dev.devt = MKDEV(uio_major, idev->minor);
idev->dev.class = &uio_class;
idev->dev.parent = parent;
@ -955,7 +956,7 @@ int __uio_register_device(struct module *owner,
if (ret)
goto err_device_create;
ret = device_register(&idev->dev);
ret = device_add(&idev->dev);
if (ret)
goto err_device_create;
@ -987,9 +988,10 @@ int __uio_register_device(struct module *owner,
err_request_irq:
uio_dev_del_attributes(idev);
err_uio_dev_add_attributes:
device_unregister(&idev->dev);
device_del(&idev->dev);
err_device_create:
uio_free_minor(idev);
put_device(&idev->dev);
return ret;
}
EXPORT_SYMBOL_GPL(__uio_register_device);