A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-24 21:54:34 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacmn: Fix memory leak for RX path of SDIO WLAN

Browse source 
There is a memory leak for RX path of SDIO WLAN if skb allocation
fails. Add condition check and free all resources for scenario.

Change-Id: Ic4a58d3d4e93f1d6d57bfb045dfdeb131b24f72a
CRs-Fixed: 2128051
This commit is contained in:
chenguo 2017-10-26 11:24:01 +08:00 • committed by snandini
commit 23b6502d88
1 changed files with 23 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

26
hif/src/sdio/hif_sdio_recv.c
View file

@ -293,10 +293,18 @@ QDF_STATUS hif_dev_alloc_and_prepare_rx_packets(struct hif_sdio_device *pdev,
/* for NO RESOURCE error, no need to flush data queue */
if (QDF_IS_STATUS_ERROR(status)
&& (status != QDF_STATUS_E_RESOURCES)) {
while (!HTC_QUEUE_EMPTY(queue))
while (!HTC_QUEUE_EMPTY(queue)) {
qdf_nbuf_t netbuf;
packet = htc_packet_dequeue(queue);
if (packet == NULL)
break;
netbuf = (qdf_nbuf_t) packet->pNetBufContext;
if (netbuf)
qdf_nbuf_free(netbuf);
}
}
if (status == QDF_STATUS_E_RESOURCES)
status = QDF_STATUS_SUCCESS;
return status;
}
@ -967,8 +975,20 @@ QDF_STATUS hif_dev_recv_message_pending_handler(struct hif_sdio_device *pdev,
hif_dev_recv_packet(pdev, packet,
packet->ActualLength,
mail_box_index);
if (QDF_IS_STATUS_ERROR(status))
if (QDF_IS_STATUS_ERROR(status)) {
while (!HTC_QUEUE_EMPTY(&recv_pkt_queue)) {
qdf_nbuf_t netbuf;
packet =
htc_packet_dequeue(&recv_pkt_queue);
if (packet == NULL)
break;
netbuf =
(qdf_nbuf_t) packet->pNetBufContext;
if (netbuf)
qdf_nbuf_free(netbuf);
}
break;
}
/* sent synchronously, queue this packet for
* synchronous completion
*/