A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-10 06:09:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

devfreq: bw_mon: check for the return value of start_monitor

Browse source 
The BWMON governor start is returning success on GOV_START event
without checking for the return value of start_monitor.
The return value of start_monitor is not being returned to
ret variable. This would cause the governor to start successfully
even when the monitor failed to start causing a NULL pointer
derefence when accessing the device attributes. Fix it by checking
the return value of start_monitor.

Change-Id: I8c1f6933d44ae4533c6b81ccda8a5c4c0da3779c
Signed-off-by: Rama Aparna Mallavarapu <aparnam@codeaurora.org>
[avajid@codeaurora.org: minor change to check ret < 0]
Signed-off-by: Amir Vajid <avajid@codeaurora.org>
This commit is contained in:
Rama Aparna Mallavarapu 2019-03-25 11:46:23 -07:00 • committed by Amir Vajid
commit 2526ddbdbe
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/devfreq/governor_bw_hwmon.c
View file

@ -599,7 +599,8 @@ static int gov_start(struct devfreq *df)
node->orig_data = df->data;
df->data = node;
if (start_monitor(df, true))
ret = start_monitor(df, true);
if (ret < 0)
goto err_start;
ret = sysfs_create_group(&df->dev.kobj, node->attr_grp);