video: fbdev: pxafb: Fix "WARNING: invalid free of devm_ allocated data"

'info->modes' got allocated with devm_kcalloc in of_get_pxafb_display.

This gives this error message:
  ./drivers/video/fbdev/pxafb.c:2238:2-7: WARNING: invalid free of devm_ allocated data

Fixes: c8f96304ec ("video: fbdev: pxafb: switch to devm_* API")
Cc: [email protected] [v4.19+]
Signed-off-by: YueHaibing <[email protected]>
Reviewed-by: Daniel Mack <[email protected]>
Cc: Robert Jarzmik <[email protected]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
This commit is contained in:
YueHaibing 2018-12-20 19:13:08 +01:00 • committed by Bartlomiej Zolnierkiewicz
commit 2607391882

View file

@ -2234,10 +2234,8 @@ static struct pxafb_mach_info *of_pxafb_of_mach_info(struct device *dev)
if (!info)
return ERR_PTR(-ENOMEM);
ret = of_get_pxafb_mode_info(dev, info);
if (ret) {
kfree(info->modes);
if (ret)
return ERR_PTR(ret);
}
/*
* On purpose, neither lccrX registers nor video memory size can be