From 2a54c015b8ee40e975294de1823f80c20206fb63 Mon Sep 17 00:00:00 2001 From: Bojun Pan Date: Thu, 5 Sep 2019 16:41:24 -0700 Subject: [PATCH] msm: ipa: Fix KW P1 issue KW tool detect the potential NULL access and buffer index overflow issue. The change is to add the proper handle for NULL response and prevent buffer index overflow. Change-Id: I0bb1b45ba6e5b0abe6c3539d451f74e19028737c Signed-off-by: Bojun Pan --- drivers/platform/msm/ipa/ipa_v3/ipa_qmi_service.c | 3 +++ drivers/platform/msm/ipa/test/ipa_ut_framework.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/platform/msm/ipa/ipa_v3/ipa_qmi_service.c b/drivers/platform/msm/ipa/ipa_v3/ipa_qmi_service.c index bec091db12b5..3df76028e261 100644 --- a/drivers/platform/msm/ipa/ipa_v3/ipa_qmi_service.c +++ b/drivers/platform/msm/ipa/ipa_v3/ipa_qmi_service.c @@ -384,6 +384,9 @@ static void ipa3_handle_mhi_vote_req(struct qmi_handle *qmi_handle, IPA_QMI_ERR_NOT_SUPPORTED_V01; } resp = &resp2; + } else { + IPAWANERR("clk_rate_valid is false\n"); + return; } } else { resp = imp_handle_vote_req(vote_req->mhi_vote); diff --git a/drivers/platform/msm/ipa/test/ipa_ut_framework.c b/drivers/platform/msm/ipa/test/ipa_ut_framework.c index 4bd4434d925b..0dfb8184fd9b 100644 --- a/drivers/platform/msm/ipa/test/ipa_ut_framework.c +++ b/drivers/platform/msm/ipa/test/ipa_ut_framework.c @@ -403,10 +403,10 @@ static ssize_t ipa_ut_dbgfs_meta_test_read(struct file *file, meta_type = (long)(file->private_data); IPA_UT_DBG("Meta test type %ld\n", meta_type); - buf = kmalloc(IPA_UT_DEBUG_READ_BUF_SIZE, GFP_KERNEL); + buf = kmalloc(IPA_UT_DEBUG_READ_BUF_SIZE + 1, GFP_KERNEL); if (!buf) { IPA_UT_ERR("failed to allocate %d bytes\n", - IPA_UT_DEBUG_READ_BUF_SIZE); + IPA_UT_DEBUG_READ_BUF_SIZE + 1); cnt = 0; goto unlock_mutex; }