A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-11-10 12:52:37 -05:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Fix memory leaks when WMI send fails

Browse source 
Calls to wmi_unified_cmd_send() do not cleanup the passed buffer on
failure. Ensure all calls to wmi_unified_cmd_send() handle the failure
case and free the passed buffer.

Change-Id: I222bfbafc7e1f2eb0e11a54775a5d01a7a339521
CRs-Fixed: 1100325
This commit is contained in:
Dustin Brown 2016-12-02 14:47:48 -08:00 • committed by qcabuildsw
commit 2afb6f5c96
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
core/wma/src/wma_features.c
View file

@ -5558,6 +5558,8 @@ QDF_STATUS wma_process_get_peer_info_req
ret = wmi_unified_cmd_send(wma->wmi_handle, buf, len,
WMI_PEER_INFO_REQ_CMDID);
if (ret != QDF_STATUS_SUCCESS)
wmi_buf_free(buf);
WMA_LOGE("IBSS get peer info cmd sent len: %d, vdev %d"
" command id: %d, status: %d", len,
@ -5649,6 +5651,8 @@ QDF_STATUS wma_process_rmc_enable_ind(tp_wma_handle wma)
ret = wmi_unified_cmd_send(wma->wmi_handle, buf, len,
WMI_RMC_SET_MODE_CMDID);
if (ret != QDF_STATUS_SUCCESS)
wmi_buf_free(buf);
WMA_LOGE("Enable RMC cmd sent len: %d, vdev %d" " command id: %d,"
" status: %d", len, vdev_id, WMI_RMC_SET_MODE_CMDID, ret);
@ -5699,6 +5703,8 @@ QDF_STATUS wma_process_rmc_disable_ind(tp_wma_handle wma)
ret = wmi_unified_cmd_send(wma->wmi_handle, buf, len,
WMI_RMC_SET_MODE_CMDID);
if (ret != QDF_STATUS_SUCCESS)
wmi_buf_free(buf);
WMA_LOGE("Disable RMC cmd sent len: %d, vdev %d" " command id: %d,"
" status: %d", len, vdev_id, WMI_RMC_SET_MODE_CMDID, ret);
@ -5762,6 +5768,8 @@ QDF_STATUS wma_process_rmc_action_period_ind(tp_wma_handle wma)
ret = wmi_unified_cmd_send(wma->wmi_handle, buf, len,
WMI_RMC_SET_ACTION_PERIOD_CMDID);
if (ret != QDF_STATUS_SUCCESS)
wmi_buf_free(buf);
WMA_LOGE("RMC action period %d cmd sent len: %d, vdev %d"
" command id: %d, status: %d", periodicity_msec,

2
core/wma/src/wma_scan_roam.c
View file

@ -2812,7 +2812,7 @@ static QDF_STATUS wma_switch_channel(tp_wma_handle wma,
if (ret < 0) {
WMA_LOGP("%s: Failed to send vdev start command", __func__);
qdf_nbuf_free(buf);
wmi_buf_free(buf);
return QDF_STATUS_E_FAILURE;
}