From 2c30b06474b0bc5ebb9cbec208c252b4147dc940 Mon Sep 17 00:00:00 2001 From: Vivek Aknurwar Date: Fri, 29 May 2020 18:10:11 -0700 Subject: [PATCH] clk: qcom: gdsc-regulator: Fix using uninitialized variable Fix printing stale regval value in case of votable gdsc and if driver observes error is gdsc polling. Change-Id: I20c6e28fa8ed9ca5eea9f2a4c57b22c424ee262a Signed-off-by: Vivek Aknurwar --- drivers/clk/qcom/gdsc-regulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gdsc-regulator.c b/drivers/clk/qcom/gdsc-regulator.c index acef2c2bf04f..332a964ceb7e 100644 --- a/drivers/clk/qcom/gdsc-regulator.c +++ b/drivers/clk/qcom/gdsc-regulator.c @@ -374,9 +374,11 @@ static int gdsc_disable(struct regulator_dev *rdev) udelay(TIMEOUT_US); } else { ret = poll_gdsc_status(sc, DISABLED); - if (ret) + if (ret) { + regmap_read(sc->regmap, REG_OFFSET, ®val); dev_err(&rdev->dev, "%s disable timed out: 0x%x\n", sc->rdesc.name, regval); + } } if (sc->domain_addr) {