usb: musb: fix PHY power on/off

commi 30a70b0 (usb: musb: fix obex in g_nokia.ko
causing kernel panic) removed phy_power_on()
and phy_power_off() calls from runtime PM callbacks
but it failed to note that the driver depended
on pm_runtime_get_sync() calls to power up the PHY,
thus leaving some platforms without any means to
have a working PHY.

Fix that by enabling the phy during omap2430_musb_init()
and killing it in omap2430_musb_exit().

Fixes: 30a70b0 (usb: musb: fix obex in g_nokia.ko causing kernel panic)
Cc: <[email protected]> # v3.14
Cc: Pali Rohár <[email protected]>
Cc: Ivaylo Dimitrov <[email protected]>
Reported-by: Michael Scott <[email protected]>
Tested-by: Michael Scott <[email protected]>
Tested-by: Stefan Roese <[email protected]>
Reported-by: Rabin Vincent <[email protected]>
Signed-off-by: Felipe Balbi <[email protected]>
This commit is contained in:
Felipe Balbi 2014-03-28 14:31:47 -05:00
commit 3063a12be2

View file

@ -416,6 +416,7 @@ static int omap2430_musb_init(struct musb *musb)
omap_musb_set_mailbox(glue);
phy_init(musb->phy);
phy_power_on(musb->phy);
pm_runtime_put_noidle(musb->controller);
return 0;
@ -478,6 +479,7 @@ static int omap2430_musb_exit(struct musb *musb)
del_timer_sync(&musb_idle_timer);
omap2430_low_level_exit(musb);
phy_power_off(musb->phy);
phy_exit(musb->phy);
return 0;