mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-30 11:41:38 -04:00
userns: Don't allow creation if the user is chrooted
Guarantee that the policy of which files may be access that is established by setting the root directory will not be violated by user namespaces by verifying that the root directory points to the root of the mount namespace at the time of user namespace creation. Changing the root is a privileged operation, and as a matter of policy it serves to limit unprivileged processes to files below the current root directory. For reasons of simplicity and comprehensibility the privilege to change the root directory is gated solely on the CAP_SYS_CHROOT capability in the user namespace. Therefore when creating a user namespace we must ensure that the policy of which files may be access can not be violated by changing the root directory. Anyone who runs a processes in a chroot and would like to use user namespace can setup the same view of filesystems with a mount namespace instead. With this result that this is not a practical limitation for using user namespaces. Cc: [email protected] Acked-by: Serge Hallyn <[email protected]> Reported-by: Andy Lutomirski <[email protected]> Signed-off-by: "Eric W. Biederman" <[email protected]>
This commit is contained in:
parent
eddc0a3abf
commit
3151527ee0
3 changed files with 35 additions and 0 deletions
|
|
@ -2732,6 +2732,30 @@ bool our_mnt(struct vfsmount *mnt)
|
|||
return check_mnt(real_mount(mnt));
|
||||
}
|
||||
|
||||
bool current_chrooted(void)
|
||||
{
|
||||
/* Does the current process have a non-standard root */
|
||||
struct path ns_root;
|
||||
struct path fs_root;
|
||||
bool chrooted;
|
||||
|
||||
/* Find the namespace root */
|
||||
ns_root.mnt = ¤t->nsproxy->mnt_ns->root->mnt;
|
||||
ns_root.dentry = ns_root.mnt->mnt_root;
|
||||
path_get(&ns_root);
|
||||
while (d_mountpoint(ns_root.dentry) && follow_down_one(&ns_root))
|
||||
;
|
||||
|
||||
get_fs_root(current->fs, &fs_root);
|
||||
|
||||
chrooted = !path_equal(&fs_root, &ns_root);
|
||||
|
||||
path_put(&fs_root);
|
||||
path_put(&ns_root);
|
||||
|
||||
return chrooted;
|
||||
}
|
||||
|
||||
static void *mntns_get(struct task_struct *task)
|
||||
{
|
||||
struct mnt_namespace *ns = NULL;
|
||||
|
|
|
|||
Loading…
Reference in a new issue