From 31cf1ba57764f6a856057d6e6cc881c8d2fe9b99 Mon Sep 17 00:00:00 2001 From: jitiphil Date: Fri, 11 May 2018 15:54:38 +0530 Subject: [PATCH] qcacld-3.0: Invalid checks for operating channel validation Inside hdd_ndi_create_req_handler(), we need to check if the operating channel is valid. The current checks do not ensure the operating channel is checked against all valid values. Correct the check condition to validate the operating channel against all valid values. Change-Id: I01c035b996ab26779ee005bef437393875fdd95a CRs-Fixed: 2233118 --- core/hdd/src/wlan_hdd_nan_datapath.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/hdd/src/wlan_hdd_nan_datapath.c b/core/hdd/src/wlan_hdd_nan_datapath.c index 7443a52781ef..ffa5c44d31f7 100644 --- a/core/hdd/src/wlan_hdd_nan_datapath.c +++ b/core/hdd/src/wlan_hdd_nan_datapath.c @@ -533,9 +533,9 @@ int hdd_ndi_start(uint8_t vdev_id) * interface does not have any such formal requests. The NDI * create request is responsible for starting the BSS as well. */ - if (op_channel != NAN_SOCIAL_CHANNEL_2_4GHZ || - op_channel != NAN_SOCIAL_CHANNEL_5GHZ_LOWER_BAND || - op_channel != NAN_SOCIAL_CHANNEL_5GHZ_UPPER_BAND) { + if (op_channel != NAN_SOCIAL_CHANNEL_2_4GHZ && + op_channel != NAN_SOCIAL_CHANNEL_5GHZ_LOWER_BAND && + op_channel != NAN_SOCIAL_CHANNEL_5GHZ_UPPER_BAND) { /* start NDI on the default 2.4 GHz social channel */ op_channel = NAN_SOCIAL_CHANNEL_2_4GHZ; }