A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-28 18:51:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

Browse source 
if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition. The reason being BUG_ON won't execute the condition when
CONFIG_BUG is not defined.

Inspired-by: J. Bruce Fields <[email protected]>
Suggested-by: Julia Lawall <[email protected]>
Acked-by: Julia Lawall <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
This commit is contained in:
Fabian Frederick 2015-04-09 22:58:04 +02:00 • committed by Michal Marek
commit 33236415ec
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/coccinelle/misc/bugon.cocci
View file

@ -57,6 +57,6 @@ coccilib.org.print_todo(p[0], "WARNING use BUG_ON")
p << r.p;
@@
msg="WARNING: Use BUG_ON"
msg="WARNING: Use BUG_ON instead of if condition followed by BUG.\nPlease make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)"
coccilib.report.print_report(p[0], msg)