From 3822826445671bd6df123114df9947bcf6c49189 Mon Sep 17 00:00:00 2001 From: Edayilliam Jayadev Date: Mon, 18 Jun 2018 16:00:31 +0530 Subject: [PATCH] qcacmn: fix api for getting first vdev As per the current design we are trying to take a ref for the vdev even when there are no active vdev. Fix this by adding a NULL check. CRs-Fixed: 2262983 Change-Id: Iac62c9d0e1138c3d150a179546ad7793ff61e3db --- target_if/spectral/target_if_spectral.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target_if/spectral/target_if_spectral.c b/target_if/spectral/target_if_spectral.c index b64e7cb66bbe..70f98bbf1c55 100644 --- a/target_if/spectral/target_if_spectral.c +++ b/target_if/spectral/target_if_spectral.c @@ -75,14 +75,13 @@ target_if_spectral_get_vdev(struct target_if_spectral *spectral) wlan_objmgr_pdev_release_ref(pdev, WLAN_SPECTRAL_ID); + if (!first_vdev) + return NULL; + if (wlan_objmgr_vdev_try_get_ref(first_vdev, WLAN_SPECTRAL_ID) != QDF_STATUS_SUCCESS) first_vdev = NULL; - if (!first_vdev) { - spectral_warn("Unable to get first vdev of pdev."); - return NULL; - } return first_vdev; }