mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 19:21:31 -04:00
cpuidle: fix error handling in __cpuidle_register_device
Fix the error handling in __cpuidle_register_device to include the missing list_del. Move it to a label, which will simplify the error handling when coupled states are added. Reviewed-by: Santosh Shilimkar <[email protected]> Tested-by: Santosh Shilimkar <[email protected]> Reviewed-by: Kevin Hilman <[email protected]> Tested-by: Kevin Hilman <[email protected]> Signed-off-by: Colin Cross <[email protected]> Reviewed-by: Rafael J. Wysocki <[email protected]> Signed-off-by: Len Brown <[email protected]>
This commit is contained in:
parent
56cfbf74a1
commit
3af272ab75
1 changed files with 9 additions and 4 deletions
|
|
@ -403,13 +403,18 @@ static int __cpuidle_register_device(struct cpuidle_device *dev)
|
|||
|
||||
per_cpu(cpuidle_devices, dev->cpu) = dev;
|
||||
list_add(&dev->device_list, &cpuidle_detected_devices);
|
||||
if ((ret = cpuidle_add_sysfs(cpu_dev))) {
|
||||
module_put(cpuidle_driver->owner);
|
||||
return ret;
|
||||
}
|
||||
ret = cpuidle_add_sysfs(cpu_dev);
|
||||
if (ret)
|
||||
goto err_sysfs;
|
||||
|
||||
dev->registered = 1;
|
||||
return 0;
|
||||
|
||||
err_sysfs:
|
||||
list_del(&dev->device_list);
|
||||
per_cpu(cpuidle_devices, dev->cpu) = NULL;
|
||||
module_put(cpuidle_driver->owner);
|
||||
return ret;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
|||
Loading…
Reference in a new issue