From 3b8344eceee6af0049ccd474b35e26b37df24b49 Mon Sep 17 00:00:00 2001 From: wuwl10 Date: Fri, 28 Aug 2020 13:50:19 +0800 Subject: [PATCH] ets_fps: filter unexpected double-click event Some of the user's sliding may be mistaken for double-clicking event. filtering out the min double-click interval tim to reducing the probability of unexpected double-click. Change-Id: I0b1a43d3ed7aac601865127076f5b2c51f6eb3d4 Signed-off-by: wuwl10 Reviewed-on: https://gerrit.mot.com/1735804 SLTApproved: Slta Waiver SME-Granted: SME Approvals Granted Tested-by: Jira Key Reviewed-by: Huosheng Liao Submit-Approved: Jira Key (cherry picked from commit 60cdf2a116c3e7cc321eab8038065efc98e3a3fc) Reviewed-on: https://gerrit.mot.com/1737936 --- drivers/input/misc/ets_fps_mmi/ets_navi_input.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/ets_fps_mmi/ets_navi_input.c b/drivers/input/misc/ets_fps_mmi/ets_navi_input.c index cbca691bb7c0..0b0b623d77be 100644 --- a/drivers/input/misc/ets_fps_mmi/ets_navi_input.c +++ b/drivers/input/misc/ets_fps_mmi/ets_navi_input.c @@ -213,7 +213,7 @@ static unsigned int prev_keycode; #define SINGLECLICK_INTERVAL 150 #define SINGLECLICK_INTERVAL_MIN 5 #define DOUBLECLICK_INTERVAL 300 - +#define DOUBLECLICK_INTERVAL_MIN 70 #define KEYEVENT_CLICK KEY_FPS_TAP /* 0x232 */ #define KEYEVENT_CLICK_ACTION KEY_PRESS_RELEASE @@ -438,7 +438,8 @@ void translated_command_converter(char cmd, struct etspi_data *etspi) #endif #if ENABLE_TRANSLATED_DOUBLE_CLICK if (g_SingleClick >= 2) { - if ((g_SingleClickJiffies - g_DoubleClickJiffies) < (HZ * DOUBLECLICK_INTERVAL / 1000)) { + if (((g_SingleClickJiffies - g_DoubleClickJiffies) < (HZ * DOUBLECLICK_INTERVAL / 1000)) + && ((g_SingleClickJiffies - g_DoubleClickJiffies) >= (HZ * DOUBLECLICK_INTERVAL_MIN / 1000))) { /* Double click event */ send_key_event(etspi, KEYEVENT_DOUBLECLICK, KEYEVENT_DOUBLECLICK_ACTION); g_SingleClick = 0;