A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-29 03:01:39 -04:00
Code Issues Projects Releases Packages Wiki Activity

timer: Remove meaningless .data/.function assignments

Browse source 
Several timer users needlessly reset their .function/.data fields during
their timer callback, but nothing else changes them. Some users do not
use their .data field at all. Each instance is removed here.

Signed-off-by: Kees Cook <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: Greg Kroah-Hartman <[email protected]> # for staging
Acked-by: Krzysztof Halasa <[email protected]> # for wan/hdlc*
Acked-by: Jens Axboe <[email protected]> # for amiflop
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: Jens Axboe <[email protected]>
Cc: Ganesh Krishna <[email protected]>
Cc: Aditya Shankar <[email protected]>
Link: https://lkml.kernel.org/r/20171010001032.GA119829@beast
This commit is contained in:
Kees Cook 2017-10-09 17:10:32 -07:00 • committed by Thomas Gleixner
commit 3c557df672
4 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/block/amiflop.c
View file

@ -323,7 +323,7 @@ static void fd_deselect (int drive)
}
static void motor_on_callback(unsigned long nr)
static void motor_on_callback(unsigned long ignored)
{
if (!(ciaa.pra & DSKRDY) || --on_attempts == 0) {
complete_all(&motor_on_completion);
@ -344,7 +344,6 @@ static int fd_motor_on(int nr)
fd_select(nr);
reinit_completion(&motor_on_completion);
motor_on_timer.data = nr;
mod_timer(&motor_on_timer, jiffies + HZ/2);
on_attempts = 10;