From 3df0752b05cf97ae13b2fece7a73436602db8aee Mon Sep 17 00:00:00 2001 From: Himanshu Agarwal Date: Fri, 11 Dec 2015 10:22:00 +0530 Subject: [PATCH] qcacld 3.0: Fix return type of few "cdf_atomic" APIs Propagation from qcacld 2.0 to qcacld 3.0 The atomic variables are of integer type but "cdf_atomic_read", "cdf_atomic_dec_and_test" and "cdf_atomic_inc_return" APIs have return type of unsigned int. Because of this, these APIs return positive value even when it is negative. This fix change the return value of "cdf_atomic_read", "cdf_atomic_dec_and_test" and "cdf_atomic_inc_return" APIs from unsigned int to int so that negative value remains negative. Change-Id: I9c4077547e1e1370bbb401af77b248944cdf25fa CRs-Fixed: 902636 --- core/cdf/inc/cdf_atomic.h | 6 +++--- core/cdf/src/i_cdf_atomic.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/cdf/inc/cdf_atomic.h b/core/cdf/inc/cdf_atomic.h index a30d52bccae7..4ae5dc5b9ab7 100644 --- a/core/cdf/inc/cdf_atomic.h +++ b/core/cdf/inc/cdf_atomic.h @@ -62,7 +62,7 @@ static inline void cdf_atomic_init(cdf_atomic_t *v) * * Return: The current value of the variable */ -static inline uint32_t cdf_atomic_read(cdf_atomic_t *v) +static inline int32_t cdf_atomic_read(cdf_atomic_t *v) { return __cdf_atomic_read(v); } @@ -122,7 +122,7 @@ static inline void cdf_atomic_sub(int i, cdf_atomic_t *v) * true (non-zero) if the new value is zero, * or false (0) if the new value is non-zero */ -static inline uint32_t cdf_atomic_dec_and_test(cdf_atomic_t *v) +static inline int32_t cdf_atomic_dec_and_test(cdf_atomic_t *v) { return __cdf_atomic_dec_and_test(v); } @@ -144,7 +144,7 @@ static inline void cdf_atomic_set(cdf_atomic_t *v, int i) * * Return: The current value of the variable */ -static inline uint32_t cdf_atomic_inc_return(cdf_atomic_t *v) +static inline int32_t cdf_atomic_inc_return(cdf_atomic_t *v) { return __cdf_atomic_inc_return(v); } diff --git a/core/cdf/src/i_cdf_atomic.h b/core/cdf/src/i_cdf_atomic.h index 7c08eb982a78..178c3275b490 100644 --- a/core/cdf/src/i_cdf_atomic.h +++ b/core/cdf/src/i_cdf_atomic.h @@ -40,7 +40,7 @@ static inline CDF_STATUS __cdf_atomic_init(__cdf_atomic_t *v) return CDF_STATUS_SUCCESS; } -static inline uint32_t __cdf_atomic_read(__cdf_atomic_t *v) +static inline int32_t __cdf_atomic_read(__cdf_atomic_t *v) { return atomic_read(v); } @@ -72,7 +72,7 @@ static inline void __cdf_atomic_sub(int i, __cdf_atomic_t *v) atomic_sub(i, v); } -static inline uint32_t __cdf_atomic_dec_and_test(__cdf_atomic_t *v) +static inline int32_t __cdf_atomic_dec_and_test(__cdf_atomic_t *v) { return atomic_dec_and_test(v); } @@ -82,7 +82,7 @@ static inline void __cdf_atomic_set(__cdf_atomic_t *v, int i) atomic_set(v, i); } -static inline uint32_t __cdf_atomic_inc_return(__cdf_atomic_t *v) +static inline int32_t __cdf_atomic_inc_return(__cdf_atomic_t *v) { return atomic_inc_return(v); }