A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-25 06:03:36 -04:00
Code Issues Projects Releases Packages Wiki Activity

slim-msm-ngd: Fix unbalanced core irq disable from ndg_slim_enable

Browse source 
The 'commit 5adc2a6e19 ("slim-msm-ngd: Disable core irq
in SSR/PDR Down notification")' added irq_enable and disable from
ngd_slim_enable function. irq will be enabled only if msm_slim_qmi_init
success where as disabled by default in else block. If QMI init is
failed we will disable the IRQ twice during SSR testing.

As the interrupt line is not enabled, capability exchange is timing out and
leading to freed memory access inside ngd_xfer_msg.

Move irq enable in ndg_slim_enable without depending on QMI init.

Change-Id: Id32b0d283b1653bb4085231694031b0df126cf4b
Signed-off-by: Chandana Kishori Chiluveru <cchiluve@codeaurora.org>
This commit is contained in:
Chandana Kishori Chiluveru 2021-02-06 13:11:20 +05:30
commit 3f42369d8f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/slimbus/slim-msm-ngd.c
View file

@ -1541,10 +1541,10 @@ static int ngd_slim_enable(struct msm_slim_ctrl *dev, bool enable)
int ret = 0;
if (enable) {
enable_irq(dev->irq);
ret = msm_slim_qmi_init(dev, false);
/* controller state should be in sync with framework state */
if (!ret) {
enable_irq(dev->irq);
complete(&dev->qmi.qmi_comp);
if (!pm_runtime_enabled(dev->dev) ||
!pm_runtime_suspended(dev->dev))