From 3fd069ff0c378bab2ce25e2db9646596acb08f07 Mon Sep 17 00:00:00 2001 From: liuyc20 Date: Mon, 7 Dec 2020 18:18:08 +0800 Subject: [PATCH] usbnet: correct usb_ether_xmit return value enum netdev_tx { NETDEV_TX_OK = 0x00, /* driver took care of packet */ NETDEV_TX_BUSY = 0x10, /* driver tx path was busy*/ }; typedef enum netdev_tx netdev_tx_t; Change-Id: I8199a0c47b59149f679af5b77463d9e87885fc9c Signed-off-by: liuyc20 Reviewed-on: https://gerrit.mot.com/1820760 SLTApproved: Slta Waiver SME-Granted: SME Approvals Granted Tested-by: Jira Key Reviewed-by: Yonghua Yan Reviewed-by: Huosheng Liao Submit-Approved: Jira Key --- drivers/moto_f_usbnet/f_usbnet.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/moto_f_usbnet/f_usbnet.c b/drivers/moto_f_usbnet/f_usbnet.c index 0b05e30a6627..167b64d0baa0 100644 --- a/drivers/moto_f_usbnet/f_usbnet.c +++ b/drivers/moto_f_usbnet/f_usbnet.c @@ -357,14 +357,14 @@ static netdev_tx_t usb_ether_xmit(struct sk_buff *skb, struct net_device *dev) dev_kfree_skb_any(skb); USBNETDBG(context, "%s:bulk_in end point is disabled\n", __func__); - return 0; + return NETDEV_TX_OK; } if (!context->bulk_in->enabled) { dev_kfree_skb_any(skb); USBNETDBG(context, "%s: bulk_in didn't enabled\n", __func__); - return 0; + return NETDEV_TX_OK; } req = usb_get_xmit_request(STOP_QUEUE, dev); @@ -372,7 +372,7 @@ static netdev_tx_t usb_ether_xmit(struct sk_buff *skb, struct net_device *dev) if (!req) { USBNETDBG(context, "%s: could not obtain tx request\n", __func__); - return 1; + return NETDEV_TX_BUSY; } /* Add 4 bytes CRC */ @@ -400,7 +400,7 @@ static netdev_tx_t usb_ether_xmit(struct sk_buff *skb, struct net_device *dev) "%s: could not queue tx request\n", __func__); } - return 0; + return NETDEV_TX_OK; } static int usb_ether_open(struct net_device *dev)