From 4079b4b464e6fb6475de7331969b89088ff6f256 Mon Sep 17 00:00:00 2001 From: Mohit Khanna Date: Thu, 15 Nov 2018 16:05:53 -0800 Subject: [PATCH] qcacld-3.0: Remove un-initialized lock from DP thread DP RX thread is using an un-initialized lock during suspend/resume routine. This lock is not needed as the code is executed only by a single execution context. Remove usage of un-initialized lock. CRs-Fixed: 2351010 Change-Id: I656562fe3ca73a5044163008a44ffae416a6a7fa --- core/dp/txrx3.0/dp_rx_thread.c | 2 -- core/dp/txrx3.0/dp_rx_thread.h | 1 - 2 files changed, 3 deletions(-) diff --git a/core/dp/txrx3.0/dp_rx_thread.c b/core/dp/txrx3.0/dp_rx_thread.c index 1befe8967cce..a448757dd97e 100644 --- a/core/dp/txrx3.0/dp_rx_thread.c +++ b/core/dp/txrx3.0/dp_rx_thread.c @@ -328,10 +328,8 @@ static int dp_rx_thread_sub_loop(struct dp_rx_thread *rx_thread, bool *shutdown) dp_debug("received suspend ind (%s) id %d pid %d", qdf_get_current_comm(), rx_thread->id, qdf_get_current_pid()); - qdf_spin_lock(&rx_thread->lock); qdf_event_reset(&rx_thread->resume_event); qdf_event_set(&rx_thread->suspend_event); - qdf_spin_unlock(&rx_thread->lock); dp_debug("waiting for resume (%s) id %d pid %d", qdf_get_current_comm(), rx_thread->id, qdf_get_current_pid()); diff --git a/core/dp/txrx3.0/dp_rx_thread.h b/core/dp/txrx3.0/dp_rx_thread.h index 6b7d661f68de..9a3a06213bd7 100644 --- a/core/dp/txrx3.0/dp_rx_thread.h +++ b/core/dp/txrx3.0/dp_rx_thread.h @@ -84,7 +84,6 @@ struct dp_rx_thread_stats { */ struct dp_rx_thread { qdf_thread_t *task; - qdf_spinlock_t lock; qdf_event_t start_event; qdf_event_t suspend_event; qdf_event_t resume_event;