RTC/watchdog: M41T80: fix a potential use of unitialized data

Watchdog handlers within the driver make use of "save_client" -- make sure it
has been initalized before the handlers are registered.

Signed-off-by: Maciej W. Rozycki <[email protected]>
Cc: Alessandro Zummo <[email protected]>
Cc: Alexander Bigga <[email protected]>
Cc: Wim Van Sebroeck <[email protected]>
Cc: David Brownell <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
Maciej W. Rozycki 2008-05-12 14:02:35 -07:00 • committed by Linus Torvalds
commit 417607d05f

View file

@ -803,6 +803,7 @@ static int m41t80_probe(struct i2c_client *client,
#ifdef CONFIG_RTC_DRV_M41T80_WDT
if (clientdata->features & M41T80_FEATURE_HT) {
save_client = client;
rc = misc_register(&wdt_dev);
if (rc)
goto exit;
@ -811,7 +812,6 @@ static int m41t80_probe(struct i2c_client *client,
misc_deregister(&wdt_dev);
goto exit;
}
save_client = client;
}
#endif
return 0;