A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-13 00:00:00 -04:00
Code Issues Projects Releases Packages Wiki Activity

ufs: ufs-qcom: Fix racing caused by ufs_qcom_testbus_config()

Browse source 
If func ufs_qcom_testbus_config() is invoked from ufshcd_suspend/resume
and/or clk gate/ungate context, pm_runtime_get_sync() and ufshcd_hold()
will flush the contexts calling ufs_qcom_testbus_config(), causing racing
problems. Fix it by removing the unnecessary calls of pm_runtime_get_sync()
and ufshcd_hold().

Change-Id: Iada1e777de0cafaf8c9b972fcace65399ea9668d
Signed-off-by: Can Guo <cang@codeaurora.org>
This commit is contained in:
Can Guo 2020-07-08 10:44:49 +08:00
commit 44db484717
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/scsi/ufs/ufs-qcom.c
View file

@ -3015,8 +3015,6 @@ int ufs_qcom_testbus_config(struct ufs_qcom_host *host)
mask <<= offset;
spin_unlock_irqrestore(hba->host->host_lock, flags);
pm_runtime_get_sync(host->hba->dev);
ufshcd_hold(host->hba, false);
ufshcd_rmwl(host->hba, TEST_BUS_SEL,
(u32)host->testbus.select_major << 19,
REG_UFS_CFG1);
@ -3029,8 +3027,6 @@ int ufs_qcom_testbus_config(struct ufs_qcom_host *host)
* committed before returning.
*/
mb();
ufshcd_release(host->hba);
pm_runtime_put_sync(host->hba->dev);
return 0;
}