mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 11:11:45 -04:00
[PATCH] set_page_dirty() return value fixes
We need set_page_dirty() to return true if it actually transitioned the page from a clean to dirty state. This wasn't right in a couple of places. Do a kernel-wide audit, fix things up. This leaves open the possibility of returning a negative errno from set_page_dirty() sometime in the future. But we don't do that at present. Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
parent
fa5a734e40
commit
4741c9fd36
5 changed files with 11 additions and 9 deletions
|
|
@ -628,8 +628,6 @@ EXPORT_SYMBOL(write_one_page);
|
|||
*/
|
||||
int __set_page_dirty_nobuffers(struct page *page)
|
||||
{
|
||||
int ret = 0;
|
||||
|
||||
if (!TestSetPageDirty(page)) {
|
||||
struct address_space *mapping = page_mapping(page);
|
||||
struct address_space *mapping2;
|
||||
|
|
@ -651,8 +649,9 @@ int __set_page_dirty_nobuffers(struct page *page)
|
|||
I_DIRTY_PAGES);
|
||||
}
|
||||
}
|
||||
return 1;
|
||||
}
|
||||
return ret;
|
||||
return 0;
|
||||
}
|
||||
EXPORT_SYMBOL(__set_page_dirty_nobuffers);
|
||||
|
||||
|
|
@ -682,8 +681,10 @@ int fastcall set_page_dirty(struct page *page)
|
|||
return (*spd)(page);
|
||||
return __set_page_dirty_buffers(page);
|
||||
}
|
||||
if (!PageDirty(page))
|
||||
SetPageDirty(page);
|
||||
if (!PageDirty(page)) {
|
||||
if (!TestSetPageDirty(page))
|
||||
return 1;
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
EXPORT_SYMBOL(set_page_dirty);
|
||||
|
|
|
|||
Loading…
Reference in a new issue