A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-30 03:27:44 -04:00
Code Issues Projects Releases Packages Wiki Activity

i2c: sis630: fix behavior after collision

Browse source 
Datasheet on collision:
	SMBus Collision (SMBCOL_STS)
	This bit is set when a SMBus Collision condition occurs and
	SMBus Host loses in the bus arbitration. The software should
	clear this bit and re-start SMBus operation.

As the status will be cleared in transaction_end, we can remove the
sis630_write and prepare to return -EAGAIN to retry.

Signed-off-by: Amaury Decrême <[email protected]>
Reviewed-by: Jean Delvare <[email protected]>
Signed-off-by: Wolfram Sang <[email protected]>
This commit is contained in:
Amaury Decrême 2013-01-28 22:21:07 +01:00 • committed by Wolfram Sang
commit 499b9194ad
1 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
drivers/i2c/busses/i2c-sis630.c
View file

@ -200,12 +200,7 @@ static int sis630_transaction_wait(struct i2c_adapter *adap, int size)
if (temp & 0x04) {
dev_err(&adap->dev, "Bus collision!\n");
result = -EIO;
/*
TBD: Datasheet say:
the software should clear this bit and restart SMBUS operation.
Should we do it or user start request again?
*/
result = -EAGAIN;
}
return result;